Possible dependency complication arising from a fix to the Manifest class

[Martijn Verburg]

Thanks Alan - will submit patch as is.

On 2 December 2011 13:18, Alan Bateman <Alan.Bateman at oracle.com> wrote:
> On 02/12/2011 12:43, Martijn Verburg wrote:
>>
>> Hi all,
>>
>> I'm cleaning up some warnings in java.util.jar.Manifest and I'm
>> replacing a deprecated String construction with one that takes a
>> Charset.
>>
>> I'm introducing the StandardCharsets import (since it's UTF_8 that is
>> required in this case) to do this. I assume introducing
>> StandardCharsets (a nio package based class) is OK for a fairly low
>> level util class like this?
>>
>> I'm more worried about any potential impact on jigsaw, at the moment
>> Manifest only pulls in java.util and java.io imports - I haven't
>> looked into jigsaw in any way shape or form to know whether adding a
>> nio dependency would cause any headaches.
>>
>> Cheers,
>> Martijn
>
> Hi Martijn,
>
> The zip code already uses StandardCharsets so it's likely it is already
> loaded. In any case, you're not introducing a new dependency in the module
> graph as nio, zip, and all the core classes are in the (prototype) base
> module.
>
> -Alan.
>