From sean.mullan at oracle.com Mon Jan 3 13:01:14 2011 From: sean.mullan at oracle.com (Sean Mullan) Date: Mon, 03 Jan 2011 16:01:14 -0500 Subject: Jigsaw test failures Message-ID: <4D22391A.1030602@oracle.com> There are a few jigsaw regression test failures: * org/openjdk/jigsaw/cli/ModuleFormatTest01.sh * org/openjdk/jigsaw/cli/jmod-signed.sh * org/openjdk/jigsaw/cli/signed-module.sh The last one is due to the cacerts file being empty. We have a fix coming for that. However, the previous two appear to be the same failure and is caused when it compares the bytes of one of the classes in an installed module with the bytes in the module file (I think). This is the stack trace from the ModuleFileFormatTest01.sh test: java.lang.RuntimeException: file compare failed 1 at ModuleFormatTest01.compare(ModuleFormatTest01.java:472) at ModuleFormatTest01.compare(ModuleFormatTest01.java:407) at ModuleFormatTest01.compare(ModuleFormatTest01.java:425) at ModuleFormatTest01.compare(ModuleFormatTest01.java:448) at ModuleFormatTest01.doTestSingleClassModule(ModuleFormatTest01.java:114) at ModuleFormatTest01.testSingleClassModule(ModuleFormatTest01.java:93) at ModuleFormatTest01.test(ModuleFormatTest01.java:301) at ModuleFormatTest01.run(ModuleFormatTest01.java:54) at ModuleFormatTest01.main(ModuleFormatTest01.java:49) Exception in thread "main" java.lang.Exception: 1/2 tests failed at ModuleFormatTest01.run(ModuleFormatTest01.java:62) at ModuleFormatTest01.main(ModuleFormatTest01.java:49) result: Failed. Execution failed: exit code 1 Has anyone looked at this more closely? Thanks, Sean From mandy.chung at oracle.com Mon Jan 3 14:53:20 2011 From: mandy.chung at oracle.com (Mandy Chung) Date: Mon, 03 Jan 2011 14:53:20 -0800 Subject: Jigsaw test failures In-Reply-To: <4D22391A.1030602@oracle.com> References: <4D22391A.1030602@oracle.com> Message-ID: <4D225360.40900@oracle.com> On 01/03/11 13:01, Sean Mullan wrote: > There are a few jigsaw regression test failures: > > * org/openjdk/jigsaw/cli/ModuleFormatTest01.sh > * org/openjdk/jigsaw/cli/jmod-signed.sh > * org/openjdk/jigsaw/cli/signed-module.sh > > The last one is due to the cacerts file being empty. We have a fix > coming for that. > > However, the previous two appear to be the same failure and is caused > when it compares the bytes of one of the classes in an installed > module with the bytes in the module file (I think). This is the stack > trace from the ModuleFileFormatTest01.sh test: > > java.lang.RuntimeException: file compare failed 1 > at ModuleFormatTest01.compare(ModuleFormatTest01.java:472) > at ModuleFormatTest01.compare(ModuleFormatTest01.java:407) > at ModuleFormatTest01.compare(ModuleFormatTest01.java:425) > at ModuleFormatTest01.compare(ModuleFormatTest01.java:448) > at > ModuleFormatTest01.doTestSingleClassModule(ModuleFormatTest01.java:114) > at > ModuleFormatTest01.testSingleClassModule(ModuleFormatTest01.java:93) > at ModuleFormatTest01.test(ModuleFormatTest01.java:301) > at ModuleFormatTest01.run(ModuleFormatTest01.java:54) > at ModuleFormatTest01.main(ModuleFormatTest01.java:49) > Exception in thread "main" java.lang.Exception: 1/2 tests failed > at ModuleFormatTest01.run(ModuleFormatTest01.java:62) > at ModuleFormatTest01.main(ModuleFormatTest01.java:49) > result: Failed. Execution failed: exit code 1 > > Has anyone looked at this more closely? Not that I know of. Do you know when these tests started to fail? Mandy From sean.mullan at oracle.com Mon Jan 3 15:12:49 2011 From: sean.mullan at oracle.com (Sean Mullan) Date: Mon, 03 Jan 2011 18:12:49 -0500 Subject: Jigsaw test failures In-Reply-To: <4D225360.40900@oracle.com> References: <4D22391A.1030602@oracle.com> <4D225360.40900@oracle.com> Message-ID: <4D2257F1.3080508@oracle.com> On 1/3/11 5:53 PM, Mandy Chung wrote: > On 01/03/11 13:01, Sean Mullan wrote: >> There are a few jigsaw regression test failures: >> >> * org/openjdk/jigsaw/cli/ModuleFormatTest01.sh >> * org/openjdk/jigsaw/cli/jmod-signed.sh >> * org/openjdk/jigsaw/cli/signed-module.sh >> >> The last one is due to the cacerts file being empty. We have a fix coming for >> that. >> >> However, the previous two appear to be the same failure and is caused when it >> compares the bytes of one of the classes in an installed module with the bytes >> in the module file (I think). This is the stack trace from the >> ModuleFileFormatTest01.sh test: >> >> java.lang.RuntimeException: file compare failed 1 >> at ModuleFormatTest01.compare(ModuleFormatTest01.java:472) >> at ModuleFormatTest01.compare(ModuleFormatTest01.java:407) >> at ModuleFormatTest01.compare(ModuleFormatTest01.java:425) >> at ModuleFormatTest01.compare(ModuleFormatTest01.java:448) >> at ModuleFormatTest01.doTestSingleClassModule(ModuleFormatTest01.java:114) >> at ModuleFormatTest01.testSingleClassModule(ModuleFormatTest01.java:93) >> at ModuleFormatTest01.test(ModuleFormatTest01.java:301) >> at ModuleFormatTest01.run(ModuleFormatTest01.java:54) >> at ModuleFormatTest01.main(ModuleFormatTest01.java:49) >> Exception in thread "main" java.lang.Exception: 1/2 tests failed >> at ModuleFormatTest01.run(ModuleFormatTest01.java:62) >> at ModuleFormatTest01.main(ModuleFormatTest01.java:49) >> result: Failed. Execution failed: exit code 1 >> >> Has anyone looked at this more closely? > > > Not that I know of. Do you know when these tests started to fail? No I don't know ... --Sean From mandy.chung at oracle.com Mon Jan 3 16:48:54 2011 From: mandy.chung at oracle.com (Mandy Chung) Date: Mon, 03 Jan 2011 16:48:54 -0800 Subject: Jigsaw test failures In-Reply-To: <4D2257F1.3080508@oracle.com> References: <4D22391A.1030602@oracle.com> <4D225360.40900@oracle.com> <4D2257F1.3080508@oracle.com> Message-ID: <4D226E76.6040007@oracle.com> On 01/03/11 15:12, Sean Mullan wrote: > On 1/3/11 5:53 PM, Mandy Chung wrote: >> On 01/03/11 13:01, Sean Mullan wrote: >>> There are a few jigsaw regression test failures: >>> >>> * org/openjdk/jigsaw/cli/ModuleFormatTest01.sh >>> * org/openjdk/jigsaw/cli/jmod-signed.sh >>> * org/openjdk/jigsaw/cli/signed-module.sh >>> >>> The last one is due to the cacerts file being empty. We have a fix >>> coming for >>> that. >>> >>> However, the previous two appear to be the same failure and is >>> caused when it >>> compares the bytes of one of the classes in an installed module with >>> the bytes >>> in the module file (I think). This is the stack trace from the >>> ModuleFileFormatTest01.sh test: >>> >>> java.lang.RuntimeException: file compare failed 1 >>> at ModuleFormatTest01.compare(ModuleFormatTest01.java:472) >>> at ModuleFormatTest01.compare(ModuleFormatTest01.java:407) >>> at ModuleFormatTest01.compare(ModuleFormatTest01.java:425) >>> at ModuleFormatTest01.compare(ModuleFormatTest01.java:448) >>> at >>> ModuleFormatTest01.doTestSingleClassModule(ModuleFormatTest01.java:114) >>> at ModuleFormatTest01.testSingleClassModule(ModuleFormatTest01.java:93) >>> at ModuleFormatTest01.test(ModuleFormatTest01.java:301) >>> at ModuleFormatTest01.run(ModuleFormatTest01.java:54) >>> at ModuleFormatTest01.main(ModuleFormatTest01.java:49) >>> Exception in thread "main" java.lang.Exception: 1/2 tests failed >>> at ModuleFormatTest01.run(ModuleFormatTest01.java:62) >>> at ModuleFormatTest01.main(ModuleFormatTest01.java:49) >>> result: Failed. Execution failed: exit code 1 >>> >>> Has anyone looked at this more closely? >> >> >> Not that I know of. Do you know when these tests started to fail? > > No I don't know ... I took a quick look at my logs but couldn't find out when these tests started to fail. I will take a look a this failure. Mandy From mandy.chung at oracle.com Wed Jan 5 10:03:51 2011 From: mandy.chung at oracle.com (Mandy Chung) Date: Wed, 05 Jan 2011 10:03:51 -0800 Subject: Jigsaw test failures In-Reply-To: <4D22391A.1030602@oracle.com> References: <4D22391A.1030602@oracle.com> Message-ID: <4D24B287.90304@oracle.com> It's a test bug that compares an original class file with a "pack-then-unpack' class file that is not the same as the original file as it's modified during the pack200 compression process. Before the fix in pack200 for (in JDK 7 b100): 6712743: pack200: should default to 150.7 pack format for classfiles without any classes. Changeset: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/43dfa39686a1 pack200 doesn't recognize class files of version 51.0 and thus doesn't do the compression and thus the class files match even after pack200. I missed this test failure when updating jigsaw repos with the recent jdk 7 builds since these tests failed with a different error before the merge: keytool error: java.security.KeyStoreException: JKS not found Here is the webrev for the test fix: http://cr.openjdk.java.net/~mchung/jigsaw/webrevs/test-fix.webrev.00/ There are pack200 regression tests that verify if pack200 generates correct class files. In addition, using the jdk-module-image to build and run tests also verify the class files installed by jmod. I think byte-by-byte class file comparison isn't necessary in these tests. So ModuleFormatTest01.java is modified just to verify the ClassFile header (the first 10 bytes). Sean, Can you review the webrev? Thanks Mandy On 01/03/11 13:01, Sean Mullan wrote: > There are a few jigsaw regression test failures: > > * org/openjdk/jigsaw/cli/ModuleFormatTest01.sh > * org/openjdk/jigsaw/cli/jmod-signed.sh > * org/openjdk/jigsaw/cli/signed-module.sh > > The last one is due to the cacerts file being empty. We have a fix > coming for that. > > However, the previous two appear to be the same failure and is caused > when it compares the bytes of one of the classes in an installed > module with the bytes in the module file (I think). This is the stack > trace from the ModuleFileFormatTest01.sh test: > > java.lang.RuntimeException: file compare failed 1 > at ModuleFormatTest01.compare(ModuleFormatTest01.java:472) > at ModuleFormatTest01.compare(ModuleFormatTest01.java:407) > at ModuleFormatTest01.compare(ModuleFormatTest01.java:425) > at ModuleFormatTest01.compare(ModuleFormatTest01.java:448) > at > ModuleFormatTest01.doTestSingleClassModule(ModuleFormatTest01.java:114) > at > ModuleFormatTest01.testSingleClassModule(ModuleFormatTest01.java:93) > at ModuleFormatTest01.test(ModuleFormatTest01.java:301) > at ModuleFormatTest01.run(ModuleFormatTest01.java:54) > at ModuleFormatTest01.main(ModuleFormatTest01.java:49) > Exception in thread "main" java.lang.Exception: 1/2 tests failed > at ModuleFormatTest01.run(ModuleFormatTest01.java:62) > at ModuleFormatTest01.main(ModuleFormatTest01.java:49) > result: Failed. Execution failed: exit code 1 > > Has anyone looked at this more closely? > > Thanks, > Sean From sean.mullan at oracle.com Wed Jan 5 11:07:11 2011 From: sean.mullan at oracle.com (Sean Mullan) Date: Wed, 05 Jan 2011 14:07:11 -0500 Subject: Jigsaw test failures In-Reply-To: <4D24B287.90304@oracle.com> References: <4D22391A.1030602@oracle.com> <4D24B287.90304@oracle.com> Message-ID: <4D24C15F.6080806@oracle.com> On 1/5/11 1:03 PM, Mandy Chung wrote: > It's a test bug that compares an original class file with a "pack-then-unpack' > class file that is not the same as the original file as it's modified during the > pack200 compression process. > > Before the fix in pack200 for (in JDK 7 b100): > 6712743: pack200: should default to 150.7 pack format for classfiles without any > classes. > Changeset: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/43dfa39686a1 > > pack200 doesn't recognize class files of version 51.0 and thus doesn't do the > compression and thus the class files match even after pack200. I missed this > test failure when updating jigsaw repos with the recent jdk 7 builds since these > tests failed with a different error before the merge: > keytool error: java.security.KeyStoreException: JKS not found > > Here is the webrev for the test fix: > http://cr.openjdk.java.net/~mchung/jigsaw/webrevs/test-fix.webrev.00/ > > There are pack200 regression tests that verify if pack200 generates correct > class files. In addition, using the jdk-module-image to build and run tests also > verify the class files installed by jmod. I think byte-by-byte class file > comparison isn't necessary in these tests. So ModuleFormatTest01.java is > modified just to verify the ClassFile header (the first 10 bytes). > > Sean, > Can you review the webrev? Fix looks good. --Sean From mandy.chung at oracle.com Wed Jan 5 13:06:08 2011 From: mandy.chung at oracle.com (mandy.chung at oracle.com) Date: Wed, 05 Jan 2011 21:06:08 +0000 Subject: hg: jigsaw/jigsaw/jdk: Fix test failure to compare classfile after compressed by pack200 instead of the original classfile. Message-ID: <20110105210639.2BABB479C9@hg.openjdk.java.net> Changeset: 3b4046e1acdb Author: mchung Date: 2011-01-05 13:04 -0800 URL: http://hg.openjdk.java.net/jigsaw/jigsaw/jdk/rev/3b4046e1acdb Fix test failure to compare classfile after compressed by pack200 instead of the original classfile. Reviewed-by: mullan ! test/org/openjdk/jigsaw/cli/ModuleFormatTest01.java ! test/org/openjdk/jigsaw/cli/jmod-signed.sh From sean.mullan at oracle.com Thu Jan 6 06:38:06 2011 From: sean.mullan at oracle.com (Sean Mullan) Date: Thu, 06 Jan 2011 09:38:06 -0500 Subject: Random jigsaw build error Message-ID: <4D25D3CE.9030706@oracle.com> Often when I am working on some local code changes which cause a build to fail, I will fix the error, and then do a "make all" from the top level directory. The build will proceed further but then fail with the following error: make[4]: Entering directory `/home/mullan/hg/jigsaw-certs/jdk/make/java/net' ... Error: Could not find class file for 'java.net.InetAddressImplFactory'. (I can send further details of the build log if necessary). If I then do a "make clean; make all", the error goes away... Has anyone else encountered this? It is frustrating because I have to do a complete rebuild from scratch. Thanks, Sean From mandy.chung at oracle.com Thu Jan 6 09:03:45 2011 From: mandy.chung at oracle.com (Mandy Chung) Date: Thu, 06 Jan 2011 09:03:45 -0800 Subject: Random jigsaw build error In-Reply-To: <4D25D3CE.9030706@oracle.com> References: <4D25D3CE.9030706@oracle.com> Message-ID: <4D25F5F1.70002@oracle.com> On 01/06/11 06:38, Sean Mullan wrote: > Often when I am working on some local code changes which cause a build > to fail, I will fix the error, and then do a "make all" from the top > level directory. The build will proceed further but then fail with the > following error: > > make[4]: Entering directory > `/home/mullan/hg/jigsaw-certs/jdk/make/java/net' > ... > Error: Could not find class file for > 'java.net.InetAddressImplFactory'. > > (I can send further details of the build log if necessary). > > If I then do a "make clean; make all", the error goes away... > > Has anyone else encountered this? It is frustrating because I have to > do a complete rebuild from scratch. > I remember seeing this but I thought it is a JDK 7 build issue (but I could be wrong). I suggest filing a bug to track this and I can look into it when I get a chance. It would be really helpful if you can try that on jdk7/jdk repo with some change that causes a build failure and see if you can reproduce the same issue. Mandy From mandy.chung at oracle.com Tue Jan 11 15:11:43 2011 From: mandy.chung at oracle.com (mandy.chung at oracle.com) Date: Tue, 11 Jan 2011 23:11:43 +0000 Subject: hg: jigsaw/jigsaw/langtools: 66 new changesets Message-ID: <20110111231348.8279647B88@hg.openjdk.java.net> Changeset: f2048d9c666e Author: mcimadamore Date: 2010-11-04 12:57 +0000 URL: http://hg.openjdk.java.net/jigsaw/jigsaw/langtools/rev/f2048d9c666e 6993963: Project Coin: Use precise exception analysis for effectively final catch parameters Summary: More precise rethrow analysis should be extended to effectively-final exception parameters. Multicatch parameters should be made implicitly final. Reviewed-by: jjg, darcy ! src/share/classes/com/sun/tools/javac/code/Flags.java ! src/share/classes/com/sun/tools/javac/comp/Attr.java ! src/share/classes/com/sun/tools/javac/comp/Flow.java ! src/share/classes/com/sun/tools/javac/resources/compiler.properties - test/tools/javac/diags/examples/MulticatchMustBeFinal.java + test/tools/javac/multicatch/Neg01eff_final.java + test/tools/javac/multicatch/Neg01eff_final.out ! test/tools/javac/multicatch/Neg02.java ! test/tools/javac/multicatch/Neg02.out + test/tools/javac/multicatch/Neg02eff_final.java + test/tools/javac/multicatch/Neg02eff_final.out ! test/tools/javac/multicatch/Neg03.java ! test/tools/javac/multicatch/Neg03.out + test/tools/javac/multicatch/Neg04eff_final.java + test/tools/javac/multicatch/Neg04eff_final.out + test/tools/javac/multicatch/Neg05.java + test/tools/javac/multicatch/Neg05.out + test/tools/javac/multicatch/Pos06.java + test/tools/javac/multicatch/Pos07.java + test/tools/javac/multicatch/model/Check.java + test/tools/javac/multicatch/model/Member.java + test/tools/javac/multicatch/model/Model01.java + test/tools/javac/multicatch/model/ModelChecker.java Changeset: e9e41c88b03e Author: mcimadamore Date: 2010-11-04 12:58 +0000 URL: http://hg.openjdk.java.net/jigsaw/jigsaw/langtools/rev/e9e41c88b03e 6714835: Safe cast is rejected (with warning) by javac Summary: Rules for unchecked cast conversion do not take into account type-containment Reviewed-by: jjg ! src/share/classes/com/sun/tools/javac/code/Types.java ! test/tools/javac/cast/6467183/T6467183a.out + test/tools/javac/cast/6714835/T6714835.java + test/tools/javac/cast/6714835/T6714835.out Changeset: e406f0645b7e Author: lana Date: 2010-11-04 15:39 -0700 URL: http://hg.openjdk.java.net/jigsaw/jigsaw/langtools/rev/e406f0645b7e Merge Changeset: 9427a3c795fc Author: jjg Date: 2010-11-06 13:53 -0700 URL: http://hg.openjdk.java.net/jigsaw/jigsaw/langtools/rev/9427a3c795fc 6998063: new Scope impl to fix Scope performance issues Reviewed-by: jjg Contributed-by: per.bothner at oracle.com ! src/share/classes/com/sun/tools/javac/code/Scope.java + test/tools/javac/6996626/Main.java + test/tools/javac/6996626/pack1/Symbol.java Changeset: a0d9d642f65b Author: jjg Date: 2010-11-09 17:49 -0800 URL: http://hg.openjdk.java.net/jigsaw/jigsaw/langtools/rev/a0d9d642f65b 6997958: test tools/javac/api/T6412669.java fails in PIT Reviewed-by: darcy ! test/tools/javac/api/T6412669.java Changeset: bce19889597e Author: mcimadamore Date: 2010-11-10 12:37 +0000 URL: http://hg.openjdk.java.net/jigsaw/jigsaw/langtools/rev/bce19889597e 6996914: Diamond inference: problem when accessing protected constructor Summary: special resolution scheme for diamond inference needs to open up protected constructors in anon inner class creation Reviewed-by: jjg ! src/share/classes/com/sun/tools/javac/comp/Attr.java + test/tools/javac/generics/diamond/6996914/T6996914a.java + test/tools/javac/generics/diamond/6996914/T6996914b.java Changeset: 58ceeff50af8 Author: mcimadamore Date: 2010-11-12 12:32 +0000 URL: http://hg.openjdk.java.net/jigsaw/jigsaw/langtools/rev/58ceeff50af8 6598108: com.sun.source.util.Trees.isAccessible incorrect Summary: JavacTrees' version of isAccessible should take into account enclosing class accessibility Reviewed-by: jjg ! src/share/classes/com/sun/tools/javac/api/JavacTrees.java ! src/share/classes/com/sun/tools/javac/comp/Resolve.java + test/tools/javac/api/6598108/T6598108.java Changeset: fdc67f5170e9 Author: mcimadamore Date: 2010-11-12 12:33 +0000 URL: http://hg.openjdk.java.net/jigsaw/jigsaw/langtools/rev/fdc67f5170e9 6999067: cast for invokeExact call gets redundant cast to warnings Summary: Xlint:cast should not report cast used in order to specify target type in polymorphic signature calls Reviewed-by: jjg ! src/share/classes/com/sun/tools/javac/comp/Flow.java + test/tools/javac/meth/XlintWarn.java Changeset: 6a99b741a1b0 Author: mcimadamore Date: 2010-11-12 12:34 +0000 URL: http://hg.openjdk.java.net/jigsaw/jigsaw/langtools/rev/6a99b741a1b0 6970016: Clean up ARM/try-with-resources implementation Summary: changed Xlint option name from -Xlint:arm to -Xlint:try Reviewed-by: jjg ! src/share/classes/com/sun/tools/javac/code/Lint.java ! src/share/classes/com/sun/tools/javac/comp/Attr.java ! src/share/classes/com/sun/tools/javac/comp/Flow.java ! src/share/classes/com/sun/tools/javac/parser/JavacParser.java ! src/share/classes/com/sun/tools/javac/resources/compiler.properties - test/tools/javac/TryWithResources/ArmLint.java - test/tools/javac/TryWithResources/ArmLint.out ! test/tools/javac/TryWithResources/ImplicitFinal.out + test/tools/javac/TryWithResources/TwrLint.java + test/tools/javac/TryWithResources/TwrLint.out ! test/tools/javac/TryWithResources/TwrOnNonResource.out ! test/tools/javac/diags/examples/ResourceClosed.java ! test/tools/javac/diags/examples/ResourceMayNotBeAssigned.java ! test/tools/javac/diags/examples/ResourceNotApplicableToType.java ! test/tools/javac/diags/examples/ResourceNotReferenced.java ! test/tools/javac/diags/examples/TryResourceNotSupported.java Changeset: a7faadc252c8 Author: lana Date: 2010-11-13 19:00 -0800 URL: http://hg.openjdk.java.net/jigsaw/jigsaw/langtools/rev/a7faadc252c8 Merge Changeset: 4328728e0409 Author: darcy Date: 2010-11-14 07:16 -0800 URL: http://hg.openjdk.java.net/jigsaw/jigsaw/langtools/rev/4328728e0409 6991528: Support making Throwable.suppressedExceptions immutable Reviewed-by: mcimadamore ! src/share/classes/com/sun/tools/javac/comp/Lower.java ! src/share/classes/com/sun/tools/javac/util/Names.java ! test/tools/javac/TryWithResources/TwrSuppression.java ! test/tools/javac/TryWithResources/TwrTests.java Changeset: a7ea58fa3e9a Author: mcimadamore Date: 2010-11-15 13:50 +0000 URL: http://hg.openjdk.java.net/jigsaw/jigsaw/langtools/rev/a7ea58fa3e9a 6985719: Alike methods in interfaces (Inheritance and Overriding) Summary: javac should report error when interface inherits unrelated method with same erasure Reviewed-by: jjg ! src/share/classes/com/sun/tools/javac/comp/Check.java + test/tools/javac/generics/6985719/T6985719a.java + test/tools/javac/generics/6985719/T6985719a.out + test/tools/javac/generics/6985719/T6985719b.java + test/tools/javac/generics/6985719/T6985719b.out + test/tools/javac/generics/6985719/T6985719c.java + test/tools/javac/generics/6985719/T6985719c.out + test/tools/javac/generics/6985719/T6985719d.java + test/tools/javac/generics/6985719/T6985719d.out + test/tools/javac/generics/6985719/T6985719e.java + test/tools/javac/generics/6985719/T6985719e.out + test/tools/javac/generics/6985719/T6985719f.java + test/tools/javac/generics/6985719/T6985719f.out + test/tools/javac/generics/6985719/T6985719g.java + test/tools/javac/generics/6985719/T6985719g.out + test/tools/javac/generics/6985719/T6985719h.java + test/tools/javac/generics/6985719/T6985719h.out Changeset: 1dd813a529cf Author: mcimadamore Date: 2010-11-15 14:41 +0000 URL: http://hg.openjdk.java.net/jigsaw/jigsaw/langtools/rev/1dd813a529cf 6999635: Multicatch: crash while compiling simple code with a multicatch parameter Summary: missing erasure when computing stackmaps leads to assertion error Reviewed-by: darcy ! src/share/classes/com/sun/tools/javac/jvm/ClassWriter.java ! src/share/classes/com/sun/tools/javac/jvm/Code.java + test/tools/javac/multicatch/Pos08.java + test/tools/javac/multicatch/Pos08eff_final.java Changeset: 621e096ca843 Author: cl Date: 2010-12-02 19:04 -0800 URL: http://hg.openjdk.java.net/jigsaw/jigsaw/langtools/rev/621e096ca843 Added tag jdk7-b120 for changeset 1dd813a529cf ! .hgtags Changeset: fb79ba6eb2e1 Author: cl Date: 2010-11-22 14:57 -0800 URL: http://hg.openjdk.java.net/jigsaw/jigsaw/langtools/rev/fb79ba6eb2e1 Added tag jdk7-b119 for changeset 814561077c44 ! .hgtags Changeset: d53cf2e9ad6c Author: ohair Date: 2010-12-03 19:45 -0800 URL: http://hg.openjdk.java.net/jigsaw/jigsaw/langtools/rev/d53cf2e9ad6c Merge ! .hgtags Changeset: abaceae7c9f8 Author: jjg Date: 2010-11-17 15:07 -0800 URL: http://hg.openjdk.java.net/jigsaw/jigsaw/langtools/rev/abaceae7c9f8 7000973: isBogus needs to be called on the to-be-returned entry, not on the current entry Reviewed-by: jjg Contributed-by: jan.lahoda at oracle.com ! src/share/classes/com/sun/tools/javac/code/Scope.java Changeset: 03177f49411d Author: jjg Date: 2010-11-18 16:13 -0800 URL: http://hg.openjdk.java.net/jigsaw/jigsaw/langtools/rev/03177f49411d 6999438: remove support for exotic identifiers from JDK 7 Reviewed-by: mcimadamore ! src/share/classes/com/sun/tools/javac/code/Source.java ! src/share/classes/com/sun/tools/javac/jvm/ClassReader.java ! src/share/classes/com/sun/tools/javac/parser/Scanner.java ! src/share/classes/com/sun/tools/javac/resources/compiler.properties - test/tools/javac/diags/examples/EmptyBytecodeIdent.java - test/tools/javac/diags/examples/IllegalBytecodeIdentChar.java - test/tools/javac/diags/examples/UnclosedBytecodeIdent.java - test/tools/javac/diags/examples/UnsupportedExoticID.java ! test/tools/javac/meth/InvokeDyn.java ! test/tools/javac/meth/InvokeDynTrans.java ! test/tools/javac/meth/InvokeDynTrans.out - test/tools/javac/quid/QuotedIdent.java - test/tools/javac/quid/QuotedIdent2.java + test/tools/javac/quid/T6999438.java + test/tools/javac/quid/T6999438.out Changeset: 2536dedd897e Author: mcimadamore Date: 2010-11-23 11:08 +0000 URL: http://hg.openjdk.java.net/jigsaw/jigsaw/langtools/rev/2536dedd897e 6995200: JDK 7 compiler crashes when type-variable is inferred from expected primitive type Summary: 15.12.2.8 should use boxing when expected type in assignment context is a primitive type Reviewed-by: jjg ! src/share/classes/com/sun/tools/javac/code/Types.java ! src/share/classes/com/sun/tools/javac/comp/Infer.java ! test/tools/javac/generics/inference/6638712/T6638712a.java + test/tools/javac/generics/inference/6995200/T6995200.java Changeset: 285896f2227a Author: jjg Date: 2010-11-23 13:32 -0800 URL: http://hg.openjdk.java.net/jigsaw/jigsaw/langtools/rev/285896f2227a 6942366: javadoc no longer inherits doc from sourcepath Reviewed-by: mcimadamore ! src/share/classes/com/sun/tools/javadoc/JavadocClassReader.java + test/tools/javadoc/6942366/T6942366.java + test/tools/javadoc/6942366/Test.java + test/tools/javadoc/6942366/p/Base.java Changeset: 79d0c48d361e Author: jjg Date: 2010-11-23 15:28 -0800 URL: http://hg.openjdk.java.net/jigsaw/jigsaw/langtools/rev/79d0c48d361e 7002346: javap test relies on location of scratch directory Reviewed-by: ksrini ! test/tools/javap/T6729471.java Changeset: d44d6d8493ad Author: jjg Date: 2010-11-29 10:09 -0800 URL: http://hg.openjdk.java.net/jigsaw/jigsaw/langtools/rev/d44d6d8493ad 7003006: add option to list directory in deterministic order Reviewed-by: mcimadamore ! src/share/classes/com/sun/tools/javac/file/JavacFileManager.java Changeset: c44234f680da Author: jjg Date: 2010-11-29 14:15 -0800 URL: http://hg.openjdk.java.net/jigsaw/jigsaw/langtools/rev/c44234f680da 6900037: javac should warn if earlier -source is used and bootclasspath not set Reviewed-by: darcy ! src/share/classes/com/sun/tools/javac/code/Lint.java ! src/share/classes/com/sun/tools/javac/file/JavacFileManager.java ! src/share/classes/com/sun/tools/javac/file/Paths.java ! src/share/classes/com/sun/tools/javac/main/JavaCompiler.java ! src/share/classes/com/sun/tools/javac/main/Main.java ! src/share/classes/com/sun/tools/javac/nio/JavacPathFileManager.java ! src/share/classes/com/sun/tools/javac/resources/compiler.properties ! src/share/classes/com/sun/tools/javac/util/BaseFileManager.java ! test/tools/javac/6341866/T6341866.java ! test/tools/javac/ClassFileModifiers/MemberModifiers.java + test/tools/javac/T6900037.java + test/tools/javac/T6900037.out ! test/tools/javac/TryWithResources/PlainTry.java ! test/tools/javac/annotations/neg/Dep.java ! test/tools/javac/diags/examples/AnnotationsNotSupported.java ! test/tools/javac/diags/examples/AssertAsIdentifier.java ! test/tools/javac/diags/examples/DiamondNotSupported.java ! test/tools/javac/diags/examples/EnumAsIdentifier.java ! test/tools/javac/diags/examples/EnumsNotSupported.java ! test/tools/javac/diags/examples/Expected2.java ! test/tools/javac/diags/examples/ForeachNotSupported.java ! test/tools/javac/diags/examples/GenericsNotSupported.java ! test/tools/javac/diags/examples/MulticatchNotSupported.java ! test/tools/javac/diags/examples/NeitherConditionalSubtype.java + test/tools/javac/diags/examples/SourceNoBootclasspath.java ! test/tools/javac/diags/examples/StaticImportNotSupported.java ! test/tools/javac/diags/examples/StringSwitchNotSupported.java ! test/tools/javac/diags/examples/TryResourceNotSupported.java ! test/tools/javac/diags/examples/TryWithoutCatchOrFinally.java ! test/tools/javac/diags/examples/UnsupportedBinaryLiteral.java ! test/tools/javac/diags/examples/UnsupportedFpLit.java ! test/tools/javac/diags/examples/UnsupportedUnderscoreLiteral.java ! test/tools/javac/diags/examples/VarargsNotSupported.java ! test/tools/javac/enum/6384542/T6384542.java ! test/tools/javac/enum/6384542/T6384542a.java ! test/tools/javac/literals/BadBinaryLiterals.java ! test/tools/javac/literals/BadUnderscoreLiterals.java ! test/tools/javac/processing/warnings/TestSourceVersionWarnings.java ! test/tools/javac/varargs/warning/Warn1.java Changeset: bcbc86cc5b31 Author: jjg Date: 2010-11-30 09:38 -0800 URL: http://hg.openjdk.java.net/jigsaw/jigsaw/langtools/rev/bcbc86cc5b31 7003477: Paths.isDefaultBootClassPath needs to be public Reviewed-by: mcimadamore ! src/share/classes/com/sun/tools/javac/file/Paths.java Changeset: 1bf969e9792f Author: lana Date: 2010-12-06 20:35 -0800 URL: http://hg.openjdk.java.net/jigsaw/jigsaw/langtools/rev/1bf969e9792f Merge - test/tools/javac/diags/examples/EmptyBytecodeIdent.java - test/tools/javac/diags/examples/IllegalBytecodeIdentChar.java - test/tools/javac/diags/examples/UnclosedBytecodeIdent.java - test/tools/javac/diags/examples/UnsupportedExoticID.java - test/tools/javac/quid/QuotedIdent.java - test/tools/javac/quid/QuotedIdent2.java Changeset: 11e7b4c0476e Author: katleman Date: 2010-12-09 21:25 -0800 URL: http://hg.openjdk.java.net/jigsaw/jigsaw/langtools/rev/11e7b4c0476e Added tag jdk7-b121 for changeset 1bf969e9792f ! .hgtags Changeset: 9968ce958706 Author: cl Date: 2010-12-16 18:18 -0800 URL: http://hg.openjdk.java.net/jigsaw/jigsaw/langtools/rev/9968ce958706 Added tag jdk7-b122 for changeset 11e7b4c0476e ! .hgtags Changeset: 4f086529d05c Author: mfang Date: 2010-12-03 20:31 -0800 URL: http://hg.openjdk.java.net/jigsaw/jigsaw/langtools/rev/4f086529d05c 6522789: [zh_CN] translation of "enclosing class" in doclet is incorrect Reviewed-by: yhuang ! src/share/classes/com/sun/tools/doclets/formats/html/resources/standard_zh_CN.properties Changeset: d9deecf9181b Author: mfang Date: 2010-12-05 18:18 -0800 URL: http://hg.openjdk.java.net/jigsaw/jigsaw/langtools/rev/d9deecf9181b Merge Changeset: a0331c79cea9 Author: ohair Date: 2010-12-15 15:30 -0800 URL: http://hg.openjdk.java.net/jigsaw/jigsaw/langtools/rev/a0331c79cea9 Merge Changeset: 98570f7ba610 Author: ohair Date: 2010-12-16 19:57 -0800 URL: http://hg.openjdk.java.net/jigsaw/jigsaw/langtools/rev/98570f7ba610 Merge Changeset: 90af8d87741f Author: bpatel Date: 2010-12-01 11:02 -0800 URL: http://hg.openjdk.java.net/jigsaw/jigsaw/langtools/rev/90af8d87741f 6851834: Javadoc doclet needs a structured approach to generate the output HTML. Reviewed-by: jjg ! src/share/classes/com/sun/tools/doclets/formats/html/AbstractExecutableMemberWriter.java ! src/share/classes/com/sun/tools/doclets/formats/html/AbstractIndexWriter.java ! src/share/classes/com/sun/tools/doclets/formats/html/AbstractMemberWriter.java ! src/share/classes/com/sun/tools/doclets/formats/html/AbstractPackageIndexWriter.java ! src/share/classes/com/sun/tools/doclets/formats/html/AbstractTreeWriter.java ! src/share/classes/com/sun/tools/doclets/formats/html/AllClassesFrameWriter.java ! src/share/classes/com/sun/tools/doclets/formats/html/AnnotationTypeOptionalMemberWriterImpl.java ! src/share/classes/com/sun/tools/doclets/formats/html/AnnotationTypeRequiredMemberWriterImpl.java ! src/share/classes/com/sun/tools/doclets/formats/html/AnnotationTypeWriterImpl.java ! src/share/classes/com/sun/tools/doclets/formats/html/ClassUseWriter.java ! src/share/classes/com/sun/tools/doclets/formats/html/ClassWriterImpl.java ! src/share/classes/com/sun/tools/doclets/formats/html/ConstantsSummaryWriterImpl.java ! src/share/classes/com/sun/tools/doclets/formats/html/ConstructorWriterImpl.java ! src/share/classes/com/sun/tools/doclets/formats/html/DeprecatedListWriter.java ! src/share/classes/com/sun/tools/doclets/formats/html/EnumConstantWriterImpl.java ! src/share/classes/com/sun/tools/doclets/formats/html/FieldWriterImpl.java ! src/share/classes/com/sun/tools/doclets/formats/html/FrameOutputWriter.java ! src/share/classes/com/sun/tools/doclets/formats/html/HelpWriter.java ! src/share/classes/com/sun/tools/doclets/formats/html/HtmlDoclet.java ! src/share/classes/com/sun/tools/doclets/formats/html/HtmlDocletWriter.java ! src/share/classes/com/sun/tools/doclets/formats/html/HtmlSerialFieldWriter.java ! src/share/classes/com/sun/tools/doclets/formats/html/HtmlSerialMethodWriter.java ! src/share/classes/com/sun/tools/doclets/formats/html/LinkFactoryImpl.java ! src/share/classes/com/sun/tools/doclets/formats/html/MethodWriterImpl.java ! src/share/classes/com/sun/tools/doclets/formats/html/NestedClassWriterImpl.java ! src/share/classes/com/sun/tools/doclets/formats/html/PackageFrameWriter.java ! src/share/classes/com/sun/tools/doclets/formats/html/PackageIndexFrameWriter.java ! src/share/classes/com/sun/tools/doclets/formats/html/PackageIndexWriter.java ! src/share/classes/com/sun/tools/doclets/formats/html/PackageTreeWriter.java ! src/share/classes/com/sun/tools/doclets/formats/html/PackageUseWriter.java ! src/share/classes/com/sun/tools/doclets/formats/html/PackageWriterImpl.java ! src/share/classes/com/sun/tools/doclets/formats/html/SerializedFormWriterImpl.java ! src/share/classes/com/sun/tools/doclets/formats/html/SingleIndexWriter.java + src/share/classes/com/sun/tools/doclets/formats/html/SourceToHTMLConverter.java ! src/share/classes/com/sun/tools/doclets/formats/html/SplitIndexWriter.java - src/share/classes/com/sun/tools/doclets/formats/html/StylesheetWriter.java ! src/share/classes/com/sun/tools/doclets/formats/html/SubWriterHolderWriter.java ! src/share/classes/com/sun/tools/doclets/formats/html/TagletWriterImpl.java ! src/share/classes/com/sun/tools/doclets/formats/html/TreeWriter.java + src/share/classes/com/sun/tools/doclets/formats/html/markup/Comment.java + src/share/classes/com/sun/tools/doclets/formats/html/markup/DocType.java + src/share/classes/com/sun/tools/doclets/formats/html/markup/HtmlAttr.java + src/share/classes/com/sun/tools/doclets/formats/html/markup/HtmlConstants.java ! src/share/classes/com/sun/tools/doclets/formats/html/markup/HtmlDocWriter.java + src/share/classes/com/sun/tools/doclets/formats/html/markup/HtmlDocument.java + src/share/classes/com/sun/tools/doclets/formats/html/markup/HtmlStyle.java + src/share/classes/com/sun/tools/doclets/formats/html/markup/HtmlTag.java + src/share/classes/com/sun/tools/doclets/formats/html/markup/HtmlTree.java ! src/share/classes/com/sun/tools/doclets/formats/html/markup/HtmlWriter.java + src/share/classes/com/sun/tools/doclets/formats/html/markup/RawHtml.java + src/share/classes/com/sun/tools/doclets/formats/html/markup/StringContent.java ! src/share/classes/com/sun/tools/doclets/formats/html/resources/standard.properties ! src/share/classes/com/sun/tools/doclets/internal/toolkit/AnnotationTypeOptionalMemberWriter.java ! src/share/classes/com/sun/tools/doclets/internal/toolkit/AnnotationTypeRequiredMemberWriter.java ! src/share/classes/com/sun/tools/doclets/internal/toolkit/AnnotationTypeWriter.java ! src/share/classes/com/sun/tools/doclets/internal/toolkit/ClassWriter.java ! src/share/classes/com/sun/tools/doclets/internal/toolkit/ConstantsSummaryWriter.java ! src/share/classes/com/sun/tools/doclets/internal/toolkit/ConstructorWriter.java + src/share/classes/com/sun/tools/doclets/internal/toolkit/Content.java ! src/share/classes/com/sun/tools/doclets/internal/toolkit/EnumConstantWriter.java ! src/share/classes/com/sun/tools/doclets/internal/toolkit/FieldWriter.java ! src/share/classes/com/sun/tools/doclets/internal/toolkit/MemberSummaryWriter.java ! src/share/classes/com/sun/tools/doclets/internal/toolkit/MethodWriter.java ! src/share/classes/com/sun/tools/doclets/internal/toolkit/NestedClassWriter.java ! src/share/classes/com/sun/tools/doclets/internal/toolkit/PackageSummaryWriter.java ! src/share/classes/com/sun/tools/doclets/internal/toolkit/SerializedFormWriter.java ! src/share/classes/com/sun/tools/doclets/internal/toolkit/builders/AbstractBuilder.java ! src/share/classes/com/sun/tools/doclets/internal/toolkit/builders/AbstractMemberBuilder.java ! src/share/classes/com/sun/tools/doclets/internal/toolkit/builders/AnnotationTypeBuilder.java ! src/share/classes/com/sun/tools/doclets/internal/toolkit/builders/AnnotationTypeOptionalMemberBuilder.java ! src/share/classes/com/sun/tools/doclets/internal/toolkit/builders/AnnotationTypeRequiredMemberBuilder.java ! src/share/classes/com/sun/tools/doclets/internal/toolkit/builders/ClassBuilder.java ! src/share/classes/com/sun/tools/doclets/internal/toolkit/builders/ConstantsSummaryBuilder.java ! src/share/classes/com/sun/tools/doclets/internal/toolkit/builders/ConstructorBuilder.java ! src/share/classes/com/sun/tools/doclets/internal/toolkit/builders/EnumConstantBuilder.java ! src/share/classes/com/sun/tools/doclets/internal/toolkit/builders/FieldBuilder.java ! src/share/classes/com/sun/tools/doclets/internal/toolkit/builders/LayoutParser.java ! src/share/classes/com/sun/tools/doclets/internal/toolkit/builders/MemberSummaryBuilder.java ! src/share/classes/com/sun/tools/doclets/internal/toolkit/builders/MethodBuilder.java ! src/share/classes/com/sun/tools/doclets/internal/toolkit/builders/PackageSummaryBuilder.java ! src/share/classes/com/sun/tools/doclets/internal/toolkit/builders/SerializedFormBuilder.java ! src/share/classes/com/sun/tools/doclets/internal/toolkit/resources/doclet.xml ! src/share/classes/com/sun/tools/doclets/internal/toolkit/resources/doclets.properties + src/share/classes/com/sun/tools/doclets/internal/toolkit/resources/stylesheet.css ! src/share/classes/com/sun/tools/doclets/internal/toolkit/util/DirectoryManager.java - src/share/classes/com/sun/tools/doclets/internal/toolkit/util/SourceToHTMLConverter.java ! src/share/classes/com/sun/tools/doclets/internal/toolkit/util/Util.java ! test/com/sun/javadoc/AccessAsciiArt/AccessAsciiArt.java ! test/com/sun/javadoc/AccessH1/AccessH1.java ! test/com/sun/javadoc/AccessSkipNav/AccessSkipNav.java ! test/com/sun/javadoc/AccessSummary/AccessSummary.java ! test/com/sun/javadoc/AuthorDD/AuthorDD.java ! test/com/sun/javadoc/JavascriptWinTitle/JavascriptWinTitle.java ! test/com/sun/javadoc/MetaTag/MetaTag.java ! test/com/sun/javadoc/ValidHtml/ValidHtml.java ! test/com/sun/javadoc/VersionNumber/VersionNumber.java ! test/com/sun/javadoc/WindowTitles/WindowTitles.java ! test/com/sun/javadoc/constantValues/TestConstantValuesDriver.java ! test/com/sun/javadoc/testClassCrossReferences/TestClassCrossReferences.java ! test/com/sun/javadoc/testClassTree/TestClassTree.java ! test/com/sun/javadoc/testConstructorIndent/TestConstructorIndent.java ! test/com/sun/javadoc/testDeprecatedDocs/TestDeprecatedDocs.java ! test/com/sun/javadoc/testDocRootInlineTag/TestDocRootInlineTag.java ! test/com/sun/javadoc/testExternalOverridenMethod/TestExternalOverridenMethod.java ! test/com/sun/javadoc/testHeadings/TestHeadings.java ! test/com/sun/javadoc/testHelpOption/TestHelpOption.java ! test/com/sun/javadoc/testHref/TestHref.java ! test/com/sun/javadoc/testHtmlDefinitionListTag/TestHtmlDefinitionListTag.java + test/com/sun/javadoc/testHtmlDocument/TestHtmlDocument.java + test/com/sun/javadoc/testHtmlDocument/testLink.html + test/com/sun/javadoc/testHtmlDocument/testMarkup.html ! test/com/sun/javadoc/testHtmlStrongTag/TestHtmlStrongTag.java ! test/com/sun/javadoc/testHtmlTableTags/TestHtmlTableTags.java ! test/com/sun/javadoc/testHtmlTag/TestHtmlTag.java ! test/com/sun/javadoc/testIndex/TestIndex.java ! test/com/sun/javadoc/testInlineLinkLabel/TestInlineLinkLabel.java ! test/com/sun/javadoc/testInterface/TestInterface.java ! test/com/sun/javadoc/testJavascript/TestJavascript.java ! test/com/sun/javadoc/testLinkOption/TestLinkOption.java ! test/com/sun/javadoc/testLinkTaglet/TestLinkTaglet.java ! test/com/sun/javadoc/testLinkToSerialForm/TestLinkToSerialForm.java ! test/com/sun/javadoc/testMemberInheritence/TestMemberInheritence.java ! test/com/sun/javadoc/testMemberSummary/TestMemberSummary.java ! test/com/sun/javadoc/testNavagation/TestNavagation.java ! test/com/sun/javadoc/testNewLanguageFeatures/TestNewLanguageFeatures.java ! test/com/sun/javadoc/testOverridenMethods/TestMultiInheritence.java ! test/com/sun/javadoc/testOverridenMethods/TestOverridenMethodDocCopy.java ! test/com/sun/javadoc/testOverridenMethods/TestOverridenPrivateMethods.java ! test/com/sun/javadoc/testOverridenMethods/TestOverridenPrivateMethodsWithPackageFlag.java ! test/com/sun/javadoc/testOverridenMethods/TestOverridenPrivateMethodsWithPrivateFlag.java ! test/com/sun/javadoc/testPackagePage/TestPackagePage.java ! test/com/sun/javadoc/testParamTaglet/TestParamTaglet.java ! test/com/sun/javadoc/testPrivateClasses/TestPrivateClasses.java ! test/com/sun/javadoc/testSerializedForm/TestSerializedForm.java ! test/com/sun/javadoc/testSerializedFormDeprecationInfo/TestSerializedFormDeprecationInfo.java ! test/com/sun/javadoc/testSimpleTag/TestSimpleTag.java ! test/com/sun/javadoc/testStylesheet/TestStylesheet.java ! test/com/sun/javadoc/testSummaryHeading/TestSummaryHeading.java ! test/com/sun/javadoc/testSuperclassInSerialForm/TestSuperClassInSerialForm.java ! test/com/sun/javadoc/testTagInheritence/TestTagInheritence.java ! test/com/sun/javadoc/testTaglets/TestTaglets.java ! test/com/sun/javadoc/testTaglets/taglets/Foo.java ! test/com/sun/javadoc/testThrowsHead/TestThrowsHead.java ! test/com/sun/javadoc/testThrowsTag/TestThrowsTag.java ! test/com/sun/javadoc/testTitleInHref/TestTitleInHref.java ! test/com/sun/javadoc/testTypeParams/TestTypeParameters.java ! test/com/sun/javadoc/testUnnamedPackage/TestUnnamedPackage.java ! test/com/sun/javadoc/testValueTag/TestValueTag.java ! test/com/sun/javadoc/testWarnings/TestWarnings.java Changeset: 7e3e9f6d013f Author: jjg Date: 2010-12-02 16:37 -0800 URL: http://hg.openjdk.java.net/jigsaw/jigsaw/langtools/rev/7e3e9f6d013f 7004029: intermittent failures compiling pack200 Summary: remove "bogus" entries from star-import scopes Reviewed-by: mcimadamore Contributed-by: per.bothner at oracle.com ! src/share/classes/com/sun/tools/javac/code/Scope.java ! src/share/classes/com/sun/tools/javac/comp/Enter.java ! src/share/classes/com/sun/tools/javac/comp/MemberEnter.java ! src/share/classes/com/sun/tools/javac/tree/JCTree.java + test/tools/javac/scope/HashCollisionTest.java + test/tools/javac/scope/StarImportTest.java Changeset: 28566c763dad Author: jjg Date: 2010-12-02 16:38 -0800 URL: http://hg.openjdk.java.net/jigsaw/jigsaw/langtools/rev/28566c763dad Merge - src/share/classes/com/sun/tools/doclets/formats/html/StylesheetWriter.java - src/share/classes/com/sun/tools/doclets/internal/toolkit/util/SourceToHTMLConverter.java Changeset: 9359f4222545 Author: mcimadamore Date: 2010-12-03 16:31 +0000 URL: http://hg.openjdk.java.net/jigsaw/jigsaw/langtools/rev/9359f4222545 6956758: NPE in com.sun.tools.javac.code.Symbol - isSubClass Summary: Use of TransTypes.cast() instead of TransTypes.coerce() causes NPE in Lower Reviewed-by: jjg ! src/share/classes/com/sun/tools/javac/comp/TransTypes.java + test/tools/javac/generics/6956758/T6956758neg.java + test/tools/javac/generics/6956758/T6956758neg.out + test/tools/javac/generics/6956758/T6956758pos.java Changeset: aa6605d883dc Author: mcimadamore Date: 2010-12-03 16:32 +0000 URL: http://hg.openjdk.java.net/jigsaw/jigsaw/langtools/rev/aa6605d883dc 7002837: Diamond: javac generates diamond inference errors when in 'finder' mode Summary: Javac should disable error messages when analyzing instance creation expression in 'diamond finder' mode Reviewed-by: jjg ! src/share/classes/com/sun/tools/javac/comp/Attr.java + test/tools/javac/generics/diamond/7002837/T7002837.java Changeset: 91b4f44c9742 Author: jjh Date: 2010-12-03 13:47 -0800 URL: http://hg.openjdk.java.net/jigsaw/jigsaw/langtools/rev/91b4f44c9742 6990209: JCK7-compiler lang/ICLS/icls006/icls00603/icls00603a.html#icls00603src test fails. Reviewed-by: jjg ! src/share/classes/com/sun/tools/javac/tree/TreeInfo.java Changeset: d53b87e07b13 Author: lana Date: 2010-12-05 15:26 -0800 URL: http://hg.openjdk.java.net/jigsaw/jigsaw/langtools/rev/d53b87e07b13 Merge Changeset: 5fb14e67c371 Author: mcimadamore Date: 2010-12-06 11:49 +0000 URL: http://hg.openjdk.java.net/jigsaw/jigsaw/langtools/rev/5fb14e67c371 7003744: Compiler error concerning final variables Summary: Flow analysis does not cleanup init/uninint bit masks after for-loop Reviewed-by: jjg ! src/share/classes/com/sun/tools/javac/comp/Flow.java ! src/share/classes/com/sun/tools/javac/util/Bits.java + test/tools/javac/DefiniteAssignment/7003744/T7003744a.java + test/tools/javac/DefiniteAssignment/7003744/T7003744b.java Changeset: 56f59723fddf Author: mcimadamore Date: 2010-12-06 11:50 +0000 URL: http://hg.openjdk.java.net/jigsaw/jigsaw/langtools/rev/56f59723fddf 7002070: If catch clause has an incompatible type, error pointer points to first exception type in list Summary: Attribution should check each component of a disjunctive type separately, rather than checking the corresponding lub() Reviewed-by: jjg ! src/share/classes/com/sun/tools/javac/comp/Attr.java + test/tools/javac/multicatch/Neg06.java + test/tools/javac/multicatch/Neg06.out Changeset: 536ee9f126b1 Author: mcimadamore Date: 2010-12-06 11:51 +0000 URL: http://hg.openjdk.java.net/jigsaw/jigsaw/langtools/rev/536ee9f126b1 5088429: varargs overloading problem Summary: compiler implementation for overload resolution w/ varargs method does not match JLS Reviewed-by: jjg ! src/share/classes/com/sun/tools/javac/comp/Resolve.java + test/tools/javac/varargs/5088429/T5088429Neg01.java + test/tools/javac/varargs/5088429/T5088429Neg01.out + test/tools/javac/varargs/5088429/T5088429Neg02.java + test/tools/javac/varargs/5088429/T5088429Neg02.out + test/tools/javac/varargs/5088429/T5088429Pos01.java + test/tools/javac/varargs/5088429/T5088429Pos02.java Changeset: 3c32c90031fd Author: jjg Date: 2010-12-07 14:13 -0800 URL: http://hg.openjdk.java.net/jigsaw/jigsaw/langtools/rev/3c32c90031fd 6999210: javac should be able to warn of anomalous conditions in classfiles Reviewed-by: mcimadamore, darcy ! src/share/classes/com/sun/tools/javac/code/Lint.java ! src/share/classes/com/sun/tools/javac/jvm/ClassReader.java ! src/share/classes/com/sun/tools/javac/resources/compiler.properties ! src/share/classes/com/sun/tools/javac/util/RawDiagnosticFormatter.java + test/tools/javac/T6999210.java ! test/tools/javac/annotations/6214965/T6214965.out ! test/tools/javac/annotations/6365854/test1.out ! test/tools/javac/annotations/6365854/test2.out ! test/tools/javac/diags/examples.not-yet.txt Changeset: acb02e1d5119 Author: jjg Date: 2010-12-08 13:42 -0800 URL: http://hg.openjdk.java.net/jigsaw/jigsaw/langtools/rev/acb02e1d5119 7004698: javap does not output CharacterRangeTable attributes correctly Reviewed-by: mcimadamore ! src/share/classes/com/sun/tools/javap/AttributeWriter.java + test/tools/javap/T7004698.java Changeset: 23fc45d3a572 Author: darcy Date: 2010-12-08 21:21 -0800 URL: http://hg.openjdk.java.net/jigsaw/jigsaw/langtools/rev/23fc45d3a572 7003550: Loosen modeling requirements for annotation processing erroneous code Reviewed-by: jjg ! src/share/classes/javax/lang/model/element/package-info.java Changeset: 5ef88773462b Author: mcimadamore Date: 2010-12-09 15:50 +0000 URL: http://hg.openjdk.java.net/jigsaw/jigsaw/langtools/rev/5ef88773462b 7005095: Cast: compile reject sensible cast from final class to interface Summary: a previous fix to cast conversion has made the compiler too strict w.r.t. final cast Reviewed-by: jjg ! src/share/classes/com/sun/tools/javac/code/Types.java + test/tools/javac/cast/7005095/T7005095neg.java + test/tools/javac/cast/7005095/T7005095neg.out + test/tools/javac/cast/7005095/T7005095pos.java Changeset: 1d625fbe6c22 Author: mcimadamore Date: 2010-12-09 15:50 +0000 URL: http://hg.openjdk.java.net/jigsaw/jigsaw/langtools/rev/1d625fbe6c22 6476118: compiler bug causes runtime ClassCastException for generics overloading Summary: compiler allows bridge methods to override unrelated method Reviewed-by: jjg ! src/share/classes/com/sun/tools/javac/code/Scope.java ! src/share/classes/com/sun/tools/javac/code/Symbol.java ! src/share/classes/com/sun/tools/javac/code/Types.java ! src/share/classes/com/sun/tools/javac/comp/Attr.java ! src/share/classes/com/sun/tools/javac/comp/Check.java + test/tools/javac/generics/6476118/T6476118a.java + test/tools/javac/generics/6476118/T6476118a.out + test/tools/javac/generics/6476118/T6476118b.java + test/tools/javac/generics/6476118/T6476118b.out + test/tools/javac/generics/6476118/T6476118c.java + test/tools/javac/generics/6476118/T6476118c.out + test/tools/javac/generics/6476118/T6476118d.java Changeset: e3df8d7a9752 Author: mcimadamore Date: 2010-12-09 15:50 +0000 URL: http://hg.openjdk.java.net/jigsaw/jigsaw/langtools/rev/e3df8d7a9752 7005371: Multicatch: assertion error while generating LocalVariableTypeTable attribute Summary: compiler crashes with assertion error if '-g' option is passed and source contains multicatch Reviewed-by: jjg ! src/share/classes/com/sun/tools/javac/jvm/ClassWriter.java + test/tools/javac/multicatch/7005371/SubTest.java + test/tools/javac/multicatch/7005371/T7005371.java Changeset: bcf44475aeee Author: jjg Date: 2010-12-09 08:24 -0800 URL: http://hg.openjdk.java.net/jigsaw/jigsaw/langtools/rev/bcf44475aeee 4917091: javac rejects array over 128 in length Reviewed-by: mcimadamore ! src/share/classes/com/sun/tools/javac/jvm/Gen.java + test/tools/javac/4917091/Test255.java + test/tools/javac/4917091/Test256a.java + test/tools/javac/4917091/Test256a.out + test/tools/javac/4917091/Test256b.java + test/tools/javac/4917091/Test256b.out Changeset: 90914ac50868 Author: jjg Date: 2010-12-09 08:48 -0800 URL: http://hg.openjdk.java.net/jigsaw/jigsaw/langtools/rev/90914ac50868 6985202: no access to doc comments from Tree API Reviewed-by: mcimadamore ! src/share/classes/com/sun/source/util/Trees.java ! src/share/classes/com/sun/tools/javac/api/JavacTrees.java + test/tools/javac/api/TestDocComments.java Changeset: 4dd1c0176d81 Author: jjg Date: 2010-12-09 18:33 -0800 URL: http://hg.openjdk.java.net/jigsaw/jigsaw/langtools/rev/4dd1c0176d81 7005856: avoid name clash for langtools when building on MacOS Reviewed-by: mcimadamore ! src/share/classes/com/sun/tools/javac/jvm/ClassReader.java Changeset: 65820d0d4a97 Author: jjg Date: 2010-12-09 19:53 -0800 URL: http://hg.openjdk.java.net/jigsaw/jigsaw/langtools/rev/65820d0d4a97 6986242: cut-n-paste error in javadoc for Trees.instance(ProcessingEnvironment) Reviewed-by: darcy ! src/share/classes/com/sun/source/util/Trees.java Changeset: 2ca5866a8dfb Author: mcimadamore Date: 2010-12-10 15:23 +0000 URL: http://hg.openjdk.java.net/jigsaw/jigsaw/langtools/rev/2ca5866a8dfb 7005671: Regression: compiler accepts invalid cast from X[] to primitive array Summary: regression in type conversion after 292 changes Reviewed-by: jjg ! src/share/classes/com/sun/tools/javac/code/Types.java + test/tools/javac/cast/7005671/T7005671.java + test/tools/javac/cast/7005671/T7005671.out Changeset: b1c98bfd4709 Author: mcimadamore Date: 2010-12-10 15:24 +0000 URL: http://hg.openjdk.java.net/jigsaw/jigsaw/langtools/rev/b1c98bfd4709 6199075: Unambiguous varargs method calls flagged as ambiguous Summary: javac does not implement overload resolution w.r.t. varargs methods as described in the JLS Reviewed-by: jjg ! src/share/classes/com/sun/tools/javac/code/Types.java ! src/share/classes/com/sun/tools/javac/comp/Resolve.java + test/tools/javac/varargs/6199075/T6199075.java Changeset: 8ec3a824f925 Author: jjg Date: 2010-12-10 07:38 -0800 URL: http://hg.openjdk.java.net/jigsaw/jigsaw/langtools/rev/8ec3a824f925 6504896: TreeMaker.Literal(Object) does not support Booleans Reviewed-by: mcimadamore ! src/share/classes/com/sun/tools/javac/parser/JavacParser.java ! src/share/classes/com/sun/tools/javac/tree/TreeMaker.java + test/tools/javac/tree/MakeLiteralTest.java Changeset: 878c8f760ded Author: jjg Date: 2010-12-12 10:05 -0800 URL: http://hg.openjdk.java.net/jigsaw/jigsaw/langtools/rev/878c8f760ded 6990134: minor (but red) findbugs warnings Reviewed-by: mcimadamore + src/share/classes/com/sun/tools/apt/main/AptJavaCompiler.java - src/share/classes/com/sun/tools/apt/main/JavaCompiler.java ! src/share/classes/com/sun/tools/apt/main/Main.java ! src/share/classes/com/sun/tools/apt/mirror/apt/FilerImpl.java ! src/share/classes/com/sun/tools/javac/code/Type.java ! src/share/classes/com/sun/tools/javac/code/Types.java ! src/share/classes/com/sun/tools/javac/comp/Resolve.java Changeset: fe43a7efd273 Author: lana Date: 2010-12-12 15:31 -0800 URL: http://hg.openjdk.java.net/jigsaw/jigsaw/langtools/rev/fe43a7efd273 Merge Changeset: dd9b5f767559 Author: lana Date: 2010-12-12 21:58 -0800 URL: http://hg.openjdk.java.net/jigsaw/jigsaw/langtools/rev/dd9b5f767559 Merge - src/share/classes/com/sun/tools/apt/main/JavaCompiler.java Changeset: 2199365892b1 Author: mcimadamore Date: 2010-12-13 14:56 +0000 URL: http://hg.openjdk.java.net/jigsaw/jigsaw/langtools/rev/2199365892b1 7006109: Add test library to simplify the task of writing automated type-system tests Summary: Types.java needs to be more stress-tested Reviewed-by: jjg + test/tools/javac/types/BoxingConversionTest.java + test/tools/javac/types/CastTest.java + test/tools/javac/types/PrimitiveConversionTest.java + test/tools/javac/types/TypeHarness.java Changeset: ffbf2b2a8611 Author: bpatel Date: 2010-12-13 13:44 -0800 URL: http://hg.openjdk.java.net/jigsaw/jigsaw/langtools/rev/ffbf2b2a8611 7006270: Several javadoc regression tests are failing on windows Reviewed-by: jjg ! src/share/classes/com/sun/tools/doclets/formats/html/ClassWriterImpl.java ! src/share/classes/com/sun/tools/doclets/formats/html/HtmlDoclet.java ! src/share/classes/com/sun/tools/doclets/formats/html/HtmlDocletWriter.java ! src/share/classes/com/sun/tools/doclets/formats/html/markup/Comment.java ! src/share/classes/com/sun/tools/doclets/formats/html/markup/DocType.java ! src/share/classes/com/sun/tools/doclets/formats/html/markup/HtmlTree.java ! src/share/classes/com/sun/tools/doclets/formats/html/markup/HtmlWriter.java ! src/share/classes/com/sun/tools/doclets/internal/toolkit/Content.java ! src/share/classes/com/sun/tools/doclets/internal/toolkit/util/Util.java ! test/com/sun/javadoc/testHtmlDocument/TestHtmlDocument.java Changeset: 2f2ead61db06 Author: bpatel Date: 2010-12-13 14:08 -0800 URL: http://hg.openjdk.java.net/jigsaw/jigsaw/langtools/rev/2f2ead61db06 Merge - src/share/classes/com/sun/tools/apt/main/JavaCompiler.java Changeset: 7b99f98b3035 Author: mcimadamore Date: 2010-12-13 15:11 -0800 URL: http://hg.openjdk.java.net/jigsaw/jigsaw/langtools/rev/7b99f98b3035 6993978: Project Coin: Compiler support of annotation to reduce varargs warnings Reviewed-by: jjg, darcy ! src/share/classes/com/sun/tools/javac/code/Source.java ! src/share/classes/com/sun/tools/javac/code/Symtab.java ! src/share/classes/com/sun/tools/javac/code/Type.java ! src/share/classes/com/sun/tools/javac/code/Types.java ! src/share/classes/com/sun/tools/javac/comp/Attr.java ! src/share/classes/com/sun/tools/javac/comp/Check.java ! src/share/classes/com/sun/tools/javac/comp/Infer.java ! src/share/classes/com/sun/tools/javac/comp/MemberEnter.java ! src/share/classes/com/sun/tools/javac/comp/Resolve.java ! src/share/classes/com/sun/tools/javac/jvm/ClassReader.java ! src/share/classes/com/sun/tools/javac/resources/compiler.properties ! src/share/classes/com/sun/tools/javac/util/List.java ! src/share/classes/com/sun/tools/javac/util/Warner.java ! test/tools/javac/diags/CheckExamples.java ! test/tools/javac/diags/RunExamples.java + test/tools/javac/diags/examples/TrustMeOnNonVarargsMeth.java + test/tools/javac/diags/examples/TrustMeOnReifiableVarargsParam.java + test/tools/javac/diags/examples/TrustMeOnVirtualMethod.java ! test/tools/javac/diags/examples/UncheckedGenericArrayCreation.java + test/tools/javac/diags/examples/UnsafeUseOfVarargsParam.java - test/tools/javac/diags/examples/VarargsFilename.java - test/tools/javac/diags/examples/VarargsFilenameAdditional.java ! test/tools/javac/diags/examples/VarargsNonReifiableType.java - test/tools/javac/diags/examples/VarargsPlural/VarargsFilename.java - test/tools/javac/diags/examples/VarargsPlural/VarargsPlural.java - test/tools/javac/diags/examples/VarargsPluralAdditional/VarargsFilename.java - test/tools/javac/diags/examples/VarargsPluralAdditional/VarargsPlural.java - test/tools/javac/diags/examples/VarargsPluralAdditional/VarargsPluralAdditional.java ! test/tools/javac/varargs/6730476/T6730476a.java ! test/tools/javac/varargs/6806876/T6806876.out + test/tools/javac/varargs/6993978/T6993978neg.java + test/tools/javac/varargs/6993978/T6993978neg.out ! test/tools/javac/varargs/warning/Warn4.java + test/tools/javac/varargs/warning/Warn5.java Changeset: a3b5b531542a Author: lana Date: 2010-12-20 21:10 -0800 URL: http://hg.openjdk.java.net/jigsaw/jigsaw/langtools/rev/a3b5b531542a Merge - src/share/classes/com/sun/tools/apt/main/JavaCompiler.java - src/share/classes/com/sun/tools/doclets/formats/html/StylesheetWriter.java - src/share/classes/com/sun/tools/doclets/internal/toolkit/util/SourceToHTMLConverter.java - test/tools/javac/diags/examples/VarargsFilename.java - test/tools/javac/diags/examples/VarargsFilenameAdditional.java - test/tools/javac/diags/examples/VarargsPlural/VarargsFilename.java - test/tools/javac/diags/examples/VarargsPlural/VarargsPlural.java - test/tools/javac/diags/examples/VarargsPluralAdditional/VarargsFilename.java - test/tools/javac/diags/examples/VarargsPluralAdditional/VarargsPlural.java - test/tools/javac/diags/examples/VarargsPluralAdditional/VarargsPluralAdditional.java Changeset: 659417e931fe Author: cl Date: 2010-12-22 15:57 -0800 URL: http://hg.openjdk.java.net/jigsaw/jigsaw/langtools/rev/659417e931fe Added tag jdk7-b123 for changeset a3b5b531542a ! .hgtags Changeset: 4868a36f6fd8 Author: ohair Date: 2010-12-28 15:54 -0800 URL: http://hg.openjdk.java.net/jigsaw/jigsaw/langtools/rev/4868a36f6fd8 6962318: Update copyright year Reviewed-by: xdono ! make/Makefile ! make/build.properties ! make/tools/CompileProperties/CompileProperties.java ! make/tools/CompileProperties/CompilePropertiesTask.java ! src/share/classes/com/sun/mirror/util/SourceOrderDeclScanner.java ! src/share/classes/com/sun/source/tree/MethodTree.java ! src/share/classes/com/sun/source/tree/Tree.java ! src/share/classes/com/sun/source/tree/TreeVisitor.java ! src/share/classes/com/sun/source/tree/TryTree.java ! src/share/classes/com/sun/source/tree/TypeParameterTree.java ! src/share/classes/com/sun/source/util/SimpleTreeVisitor.java ! src/share/classes/com/sun/source/util/TreeScanner.java ! src/share/classes/com/sun/source/util/Trees.java ! src/share/classes/com/sun/tools/apt/comp/Apt.java ! src/share/classes/com/sun/tools/apt/main/CommandLine.java ! src/share/classes/com/sun/tools/apt/main/Main.java ! src/share/classes/com/sun/tools/apt/mirror/apt/FilerImpl.java ! src/share/classes/com/sun/tools/apt/mirror/declaration/AnnotationProxyMaker.java ! src/share/classes/com/sun/tools/apt/mirror/declaration/DeclarationImpl.java ! src/share/classes/com/sun/tools/apt/mirror/type/TypeMirrorImpl.java ! src/share/classes/com/sun/tools/apt/resources/apt_ja.properties ! src/share/classes/com/sun/tools/apt/resources/apt_zh_CN.properties ! src/share/classes/com/sun/tools/classfile/ClassWriter.java ! src/share/classes/com/sun/tools/classfile/ExtendedAnnotation.java ! src/share/classes/com/sun/tools/doclets/formats/html/AbstractExecutableMemberWriter.java ! src/share/classes/com/sun/tools/doclets/formats/html/AbstractIndexWriter.java ! src/share/classes/com/sun/tools/doclets/formats/html/AbstractMemberWriter.java ! src/share/classes/com/sun/tools/doclets/formats/html/AbstractPackageIndexWriter.java ! src/share/classes/com/sun/tools/doclets/formats/html/AbstractTreeWriter.java ! src/share/classes/com/sun/tools/doclets/formats/html/AllClassesFrameWriter.java ! src/share/classes/com/sun/tools/doclets/formats/html/AnnotationTypeOptionalMemberWriterImpl.java ! src/share/classes/com/sun/tools/doclets/formats/html/AnnotationTypeRequiredMemberWriterImpl.java ! src/share/classes/com/sun/tools/doclets/formats/html/AnnotationTypeWriterImpl.java ! src/share/classes/com/sun/tools/doclets/formats/html/ClassUseWriter.java ! src/share/classes/com/sun/tools/doclets/formats/html/ClassWriterImpl.java ! src/share/classes/com/sun/tools/doclets/formats/html/ConstantsSummaryWriterImpl.java ! src/share/classes/com/sun/tools/doclets/formats/html/ConstructorWriterImpl.java ! src/share/classes/com/sun/tools/doclets/formats/html/DeprecatedListWriter.java ! src/share/classes/com/sun/tools/doclets/formats/html/EnumConstantWriterImpl.java ! src/share/classes/com/sun/tools/doclets/formats/html/FieldWriterImpl.java ! src/share/classes/com/sun/tools/doclets/formats/html/FrameOutputWriter.java ! src/share/classes/com/sun/tools/doclets/formats/html/HelpWriter.java ! src/share/classes/com/sun/tools/doclets/formats/html/HtmlDoclet.java ! src/share/classes/com/sun/tools/doclets/formats/html/HtmlDocletWriter.java ! src/share/classes/com/sun/tools/doclets/formats/html/HtmlSerialFieldWriter.java ! src/share/classes/com/sun/tools/doclets/formats/html/HtmlSerialMethodWriter.java ! src/share/classes/com/sun/tools/doclets/formats/html/LinkFactoryImpl.java ! src/share/classes/com/sun/tools/doclets/formats/html/MethodWriterImpl.java ! src/share/classes/com/sun/tools/doclets/formats/html/NestedClassWriterImpl.java ! src/share/classes/com/sun/tools/doclets/formats/html/PackageFrameWriter.java ! src/share/classes/com/sun/tools/doclets/formats/html/PackageIndexFrameWriter.java ! src/share/classes/com/sun/tools/doclets/formats/html/PackageIndexWriter.java ! src/share/classes/com/sun/tools/doclets/formats/html/PackageTreeWriter.java ! src/share/classes/com/sun/tools/doclets/formats/html/PackageUseWriter.java ! src/share/classes/com/sun/tools/doclets/formats/html/PackageWriterImpl.java ! src/share/classes/com/sun/tools/doclets/formats/html/SerializedFormWriterImpl.java ! src/share/classes/com/sun/tools/doclets/formats/html/SingleIndexWriter.java ! src/share/classes/com/sun/tools/doclets/formats/html/SourceToHTMLConverter.java ! src/share/classes/com/sun/tools/doclets/formats/html/SplitIndexWriter.java ! src/share/classes/com/sun/tools/doclets/formats/html/SubWriterHolderWriter.java ! src/share/classes/com/sun/tools/doclets/formats/html/TagletWriterImpl.java ! src/share/classes/com/sun/tools/doclets/formats/html/TreeWriter.java ! src/share/classes/com/sun/tools/doclets/formats/html/markup/HtmlDocWriter.java ! src/share/classes/com/sun/tools/doclets/formats/html/markup/HtmlWriter.java ! src/share/classes/com/sun/tools/doclets/internal/toolkit/AnnotationTypeOptionalMemberWriter.java ! src/share/classes/com/sun/tools/doclets/internal/toolkit/AnnotationTypeRequiredMemberWriter.java ! src/share/classes/com/sun/tools/doclets/internal/toolkit/AnnotationTypeWriter.java ! src/share/classes/com/sun/tools/doclets/internal/toolkit/ClassWriter.java ! src/share/classes/com/sun/tools/doclets/internal/toolkit/ConstantsSummaryWriter.java ! src/share/classes/com/sun/tools/doclets/internal/toolkit/ConstructorWriter.java ! src/share/classes/com/sun/tools/doclets/internal/toolkit/EnumConstantWriter.java ! src/share/classes/com/sun/tools/doclets/internal/toolkit/FieldWriter.java ! src/share/classes/com/sun/tools/doclets/internal/toolkit/MemberSummaryWriter.java ! src/share/classes/com/sun/tools/doclets/internal/toolkit/MethodWriter.java ! src/share/classes/com/sun/tools/doclets/internal/toolkit/NestedClassWriter.java ! src/share/classes/com/sun/tools/doclets/internal/toolkit/PackageSummaryWriter.java ! src/share/classes/com/sun/tools/doclets/internal/toolkit/SerializedFormWriter.java ! src/share/classes/com/sun/tools/doclets/internal/toolkit/builders/AbstractBuilder.java ! src/share/classes/com/sun/tools/doclets/internal/toolkit/builders/AbstractMemberBuilder.java ! src/share/classes/com/sun/tools/doclets/internal/toolkit/builders/AnnotationTypeBuilder.java ! src/share/classes/com/sun/tools/doclets/internal/toolkit/builders/AnnotationTypeOptionalMemberBuilder.java ! src/share/classes/com/sun/tools/doclets/internal/toolkit/builders/AnnotationTypeRequiredMemberBuilder.java ! src/share/classes/com/sun/tools/doclets/internal/toolkit/builders/ClassBuilder.java ! src/share/classes/com/sun/tools/doclets/internal/toolkit/builders/ConstantsSummaryBuilder.java ! src/share/classes/com/sun/tools/doclets/internal/toolkit/builders/ConstructorBuilder.java ! src/share/classes/com/sun/tools/doclets/internal/toolkit/builders/EnumConstantBuilder.java ! src/share/classes/com/sun/tools/doclets/internal/toolkit/builders/FieldBuilder.java ! src/share/classes/com/sun/tools/doclets/internal/toolkit/builders/LayoutParser.java ! src/share/classes/com/sun/tools/doclets/internal/toolkit/builders/MemberSummaryBuilder.java ! src/share/classes/com/sun/tools/doclets/internal/toolkit/builders/MethodBuilder.java ! src/share/classes/com/sun/tools/doclets/internal/toolkit/builders/PackageSummaryBuilder.java ! src/share/classes/com/sun/tools/doclets/internal/toolkit/builders/SerializedFormBuilder.java ! src/share/classes/com/sun/tools/doclets/internal/toolkit/resources/doclet.xml ! src/share/classes/com/sun/tools/doclets/internal/toolkit/util/DirectoryManager.java ! src/share/classes/com/sun/tools/doclets/internal/toolkit/util/Util.java ! src/share/classes/com/sun/tools/doclets/standard/Standard.java ! src/share/classes/com/sun/tools/javac/Launcher.java ! src/share/classes/com/sun/tools/javac/api/JavacTool.java ! src/share/classes/com/sun/tools/javac/code/Attribute.java ! src/share/classes/com/sun/tools/javac/code/Flags.java ! src/share/classes/com/sun/tools/javac/code/Kinds.java ! src/share/classes/com/sun/tools/javac/code/Lint.java ! src/share/classes/com/sun/tools/javac/code/Source.java ! src/share/classes/com/sun/tools/javac/code/Symtab.java ! src/share/classes/com/sun/tools/javac/code/Type.java ! src/share/classes/com/sun/tools/javac/code/TypeAnnotationPosition.java ! src/share/classes/com/sun/tools/javac/code/TypeAnnotations.java ! src/share/classes/com/sun/tools/javac/code/Types.java ! src/share/classes/com/sun/tools/javac/comp/Annotate.java ! src/share/classes/com/sun/tools/javac/comp/Attr.java ! src/share/classes/com/sun/tools/javac/comp/Check.java ! src/share/classes/com/sun/tools/javac/comp/Enter.java ! src/share/classes/com/sun/tools/javac/comp/Flow.java ! src/share/classes/com/sun/tools/javac/comp/Infer.java ! src/share/classes/com/sun/tools/javac/comp/MemberEnter.java ! src/share/classes/com/sun/tools/javac/comp/Resolve.java ! src/share/classes/com/sun/tools/javac/comp/TransTypes.java ! src/share/classes/com/sun/tools/javac/file/Paths.java ! src/share/classes/com/sun/tools/javac/jvm/CRTable.java ! src/share/classes/com/sun/tools/javac/jvm/ClassReader.java ! src/share/classes/com/sun/tools/javac/jvm/ClassWriter.java ! src/share/classes/com/sun/tools/javac/jvm/Code.java ! src/share/classes/com/sun/tools/javac/jvm/Gen.java ! src/share/classes/com/sun/tools/javac/jvm/Items.java ! src/share/classes/com/sun/tools/javac/jvm/Target.java ! src/share/classes/com/sun/tools/javac/main/CommandLine.java ! src/share/classes/com/sun/tools/javac/main/Main.java ! src/share/classes/com/sun/tools/javac/main/OptionName.java ! src/share/classes/com/sun/tools/javac/main/RecognizedOptions.java ! src/share/classes/com/sun/tools/javac/model/AnnotationProxyMaker.java ! src/share/classes/com/sun/tools/javac/model/JavacElements.java ! src/share/classes/com/sun/tools/javac/model/JavacTypes.java ! src/share/classes/com/sun/tools/javac/nio/JavacPathFileManager.java ! src/share/classes/com/sun/tools/javac/nio/PathFileObject.java ! src/share/classes/com/sun/tools/javac/parser/Keywords.java ! src/share/classes/com/sun/tools/javac/processing/JavacFiler.java ! src/share/classes/com/sun/tools/javac/processing/JavacMessager.java ! src/share/classes/com/sun/tools/javac/processing/JavacRoundEnvironment.java ! src/share/classes/com/sun/tools/javac/processing/PrintingProcessor.java ! src/share/classes/com/sun/tools/javac/resources/compiler.properties ! src/share/classes/com/sun/tools/javac/resources/compiler_ja.properties ! src/share/classes/com/sun/tools/javac/resources/compiler_zh_CN.properties ! src/share/classes/com/sun/tools/javac/resources/javac.properties ! src/share/classes/com/sun/tools/javac/resources/javac_ja.properties ! src/share/classes/com/sun/tools/javac/resources/javac_zh_CN.properties ! src/share/classes/com/sun/tools/javac/resources/legacy.properties ! src/share/classes/com/sun/tools/javac/tree/JCTree.java ! src/share/classes/com/sun/tools/javac/tree/Pretty.java ! src/share/classes/com/sun/tools/javac/tree/TreeCopier.java ! src/share/classes/com/sun/tools/javac/tree/TreeInfo.java ! src/share/classes/com/sun/tools/javac/tree/TreeMaker.java ! src/share/classes/com/sun/tools/javac/tree/TreeScanner.java ! src/share/classes/com/sun/tools/javac/tree/TreeTranslator.java ! src/share/classes/com/sun/tools/javac/util/AbstractDiagnosticFormatter.java ! src/share/classes/com/sun/tools/javac/util/AbstractLog.java ! src/share/classes/com/sun/tools/javac/util/BaseFileManager.java ! src/share/classes/com/sun/tools/javac/util/BasicDiagnosticFormatter.java ! src/share/classes/com/sun/tools/javac/util/Bits.java ! src/share/classes/com/sun/tools/javac/util/FatalError.java ! src/share/classes/com/sun/tools/javac/util/JCDiagnostic.java ! src/share/classes/com/sun/tools/javac/util/LayoutCharacters.java ! src/share/classes/com/sun/tools/javac/util/List.java ! src/share/classes/com/sun/tools/javac/util/Log.java ! src/share/classes/com/sun/tools/javac/util/MandatoryWarningHandler.java ! src/share/classes/com/sun/tools/javac/util/Options.java ! src/share/classes/com/sun/tools/javac/util/RawDiagnosticFormatter.java ! src/share/classes/com/sun/tools/javac/util/Warner.java ! src/share/classes/com/sun/tools/javadoc/ClassDocImpl.java ! src/share/classes/com/sun/tools/javadoc/DocEnv.java ! src/share/classes/com/sun/tools/javadoc/DocletInvoker.java ! src/share/classes/com/sun/tools/javadoc/JavadocClassReader.java ! src/share/classes/com/sun/tools/javadoc/Messager.java ! src/share/classes/com/sun/tools/javadoc/Start.java ! src/share/classes/com/sun/tools/javadoc/resources/javadoc.properties ! src/share/classes/com/sun/tools/javah/JNI.java ! src/share/classes/com/sun/tools/javah/LLNI.java ! src/share/classes/com/sun/tools/javah/Mangle.java ! src/share/classes/com/sun/tools/javah/TypeSignature.java ! src/share/classes/com/sun/tools/javah/resources/version.properties-template ! src/share/classes/com/sun/tools/javap/AnnotationWriter.java ! src/share/classes/com/sun/tools/javap/AttributeWriter.java ! src/share/classes/com/sun/tools/javap/ClassWriter.java ! src/share/classes/com/sun/tools/javap/CodeWriter.java ! src/share/classes/com/sun/tools/javap/SourceWriter.java ! src/share/classes/javax/lang/model/element/ElementKind.java ! src/share/classes/javax/lang/model/element/ElementVisitor.java ! src/share/classes/javax/lang/model/type/MirroredTypeException.java ! src/share/classes/javax/lang/model/type/MirroredTypesException.java ! src/share/classes/javax/lang/model/util/AbstractAnnotationValueVisitor6.java ! src/share/classes/javax/lang/model/util/AbstractElementVisitor6.java ! src/share/classes/javax/lang/model/util/AbstractTypeVisitor6.java ! src/share/classes/javax/lang/model/util/ElementKindVisitor6.java ! src/share/classes/javax/lang/model/util/ElementScanner6.java ! src/share/classes/javax/lang/model/util/SimpleAnnotationValueVisitor6.java ! src/share/classes/javax/lang/model/util/SimpleElementVisitor6.java ! src/share/classes/javax/lang/model/util/SimpleTypeVisitor6.java ! src/share/classes/javax/lang/model/util/TypeKindVisitor6.java ! src/share/classes/javax/tools/ToolProvider.java ! src/share/sample/javac/processing/src/CheckNamesProcessor.java ! test/com/sun/javadoc/AccessAsciiArt/AccessAsciiArt.java ! test/com/sun/javadoc/AccessH1/AccessH1.java ! test/com/sun/javadoc/AccessSkipNav/AccessSkipNav.java ! test/com/sun/javadoc/AccessSummary/AccessSummary.java ! test/com/sun/javadoc/AuthorDD/AuthorDD.java ! test/com/sun/javadoc/JavascriptWinTitle/JavascriptWinTitle.java ! test/com/sun/javadoc/MetaTag/MetaTag.java ! test/com/sun/javadoc/ValidHtml/ValidHtml.java ! test/com/sun/javadoc/VersionNumber/VersionNumber.java ! test/com/sun/javadoc/WindowTitles/WindowTitles.java ! test/com/sun/javadoc/constantValues/TestConstantValuesDriver.java ! test/com/sun/javadoc/testClassCrossReferences/TestClassCrossReferences.java ! test/com/sun/javadoc/testClassTree/TestClassTree.java ! test/com/sun/javadoc/testConstructorIndent/TestConstructorIndent.java ! test/com/sun/javadoc/testDeprecatedDocs/TestDeprecatedDocs.java ! test/com/sun/javadoc/testDocRootInlineTag/TestDocRootInlineTag.java ! test/com/sun/javadoc/testExternalOverridenMethod/TestExternalOverridenMethod.java ! test/com/sun/javadoc/testHeadings/TestHeadings.java ! test/com/sun/javadoc/testHelpOption/TestHelpOption.java ! test/com/sun/javadoc/testHref/TestHref.java ! test/com/sun/javadoc/testHtmlDefinitionListTag/TestHtmlDefinitionListTag.java ! test/com/sun/javadoc/testHtmlStrongTag/TestHtmlStrongTag.java ! test/com/sun/javadoc/testHtmlTableTags/TestHtmlTableTags.java ! test/com/sun/javadoc/testHtmlTag/TestHtmlTag.java ! test/com/sun/javadoc/testIndex/TestIndex.java ! test/com/sun/javadoc/testInlineLinkLabel/TestInlineLinkLabel.java ! test/com/sun/javadoc/testInterface/TestInterface.java ! test/com/sun/javadoc/testJavascript/TestJavascript.java ! test/com/sun/javadoc/testLinkOption/TestLinkOption.java ! test/com/sun/javadoc/testLinkTaglet/TestLinkTaglet.java ! test/com/sun/javadoc/testLinkToSerialForm/TestLinkToSerialForm.java ! test/com/sun/javadoc/testMemberInheritence/TestMemberInheritence.java ! test/com/sun/javadoc/testMemberSummary/TestMemberSummary.java ! test/com/sun/javadoc/testNavagation/TestNavagation.java ! test/com/sun/javadoc/testNewLanguageFeatures/TestNewLanguageFeatures.java ! test/com/sun/javadoc/testOverridenMethods/TestMultiInheritence.java ! test/com/sun/javadoc/testOverridenMethods/TestOverridenMethodDocCopy.java ! test/com/sun/javadoc/testOverridenMethods/TestOverridenPrivateMethods.java ! test/com/sun/javadoc/testOverridenMethods/TestOverridenPrivateMethodsWithPackageFlag.java ! test/com/sun/javadoc/testOverridenMethods/TestOverridenPrivateMethodsWithPrivateFlag.java ! test/com/sun/javadoc/testPackagePage/TestPackagePage.java ! test/com/sun/javadoc/testParamTaglet/TestParamTaglet.java ! test/com/sun/javadoc/testPrivateClasses/TestPrivateClasses.java ! test/com/sun/javadoc/testSerializedForm/TestSerializedForm.java ! test/com/sun/javadoc/testSerializedFormDeprecationInfo/TestSerializedFormDeprecationInfo.java ! test/com/sun/javadoc/testSimpleTag/TestSimpleTag.java ! test/com/sun/javadoc/testStylesheet/TestStylesheet.java ! test/com/sun/javadoc/testSummaryHeading/TestSummaryHeading.java ! test/com/sun/javadoc/testSuperclassInSerialForm/TestSuperClassInSerialForm.java ! test/com/sun/javadoc/testTagInheritence/TestTagInheritence.java ! test/com/sun/javadoc/testTaglets/TestTaglets.java ! test/com/sun/javadoc/testTaglets/taglets/Foo.java ! test/com/sun/javadoc/testThrowsHead/TestThrowsHead.java ! test/com/sun/javadoc/testThrowsTag/TestThrowsTag.java ! test/com/sun/javadoc/testTitleInHref/TestTitleInHref.java ! test/com/sun/javadoc/testTypeParams/TestTypeParameters.java ! test/com/sun/javadoc/testUnnamedPackage/TestUnnamedPackage.java ! test/com/sun/javadoc/testValueTag/TestValueTag.java ! test/com/sun/javadoc/testWarnings/TestWarnings.java ! test/tools/javac/6341866/Anno.java ! test/tools/javac/6341866/T6341866.java ! test/tools/javac/6402516/CheckLocalElements.java ! test/tools/javac/ClassFileModifiers/ClassModifiers.java ! test/tools/javac/ClassFileModifiers/MemberModifiers.java ! test/tools/javac/EarlyAssert.java ! test/tools/javac/InterfaceAssert.java ! test/tools/javac/OverrideChecks/6738538/T6738538a.java ! test/tools/javac/OverrideChecks/6738538/T6738538b.java ! test/tools/javac/T6358024.java ! test/tools/javac/T6403466.java ! test/tools/javac/T6411379.java ! test/tools/javac/T6423583.java ! test/tools/javac/T6705935.java ! test/tools/javac/ThrowsIntersection_1.java ! test/tools/javac/ThrowsIntersection_2.java ! test/tools/javac/ThrowsIntersection_3.java ! test/tools/javac/ThrowsIntersection_4.java ! test/tools/javac/annotations/6214965/T6214965.java ! test/tools/javac/annotations/6365854/T6365854.java ! test/tools/javac/annotations/neg/Constant.java ! test/tools/javac/annotations/neg/Dep.java ! test/tools/javac/annotations/pos/TrailingComma.java ! test/tools/javac/api/6421111/T6421111.java ! test/tools/javac/api/6468404/T6468404.java ! test/tools/javac/api/6731573/T6731573.java ! test/tools/javac/api/T6392782.java ! test/tools/javac/api/T6412669.java ! test/tools/javac/api/TestOperators.java ! test/tools/javac/cast/6548436/T6548436d.java ! test/tools/javac/cast/6558559/T6558559a.java ! test/tools/javac/cast/6558559/T6558559b.java ! test/tools/javac/cast/6586091/T6586091.java ! test/tools/javac/danglingDep/DepX.java ! test/tools/javac/danglingDep/NoDepX.java ! test/tools/javac/danglingDep/Test1.java ! test/tools/javac/depOverrides/annotation/Test1.java ! test/tools/javac/depOverrides/annotation/Test2.java ! test/tools/javac/depOverrides/doccomment/Test1.java ! test/tools/javac/depOverrides/doccomment/Test2.java ! test/tools/javac/diags/examples/BadSourceFileHeader/sourcepath/p/A.java ! test/tools/javac/enum/6424358/T6424358.java ! test/tools/javac/enum/T6724345.java ! test/tools/javac/generics/Casting.java ! test/tools/javac/generics/Casting3.java ! test/tools/javac/generics/Casting4.java ! test/tools/javac/generics/InnerInterface1.java ! test/tools/javac/generics/InnerInterface2.java ! test/tools/javac/generics/Multibound1.java ! test/tools/javac/generics/MultipleInheritance.java ! test/tools/javac/generics/NameOrder.java ! test/tools/javac/generics/PermuteBound.java ! test/tools/javac/generics/PrimitiveVariant.java ! test/tools/javac/generics/T6557954.java ! test/tools/javac/generics/T6751514.java ! test/tools/javac/generics/T6869075.java ! test/tools/javac/generics/inference/6569789/T6569789.java ! test/tools/javac/generics/inference/6650759/T6650759a.java ! test/tools/javac/generics/typevars/5060485/Compatibility.java ! test/tools/javac/generics/typevars/5060485/Compatibility02.java ! test/tools/javac/generics/typevars/T6880344.java ! test/tools/javac/generics/wildcards/T6732484.java ! test/tools/javac/mandatoryWarnings/deprecated/Test.java ! test/tools/javac/mandatoryWarnings/unchecked/Test.java ! test/tools/javac/meth/InvokeMHTrans.java ! test/tools/javac/nio/compileTest/CompileTest.java ! test/tools/javac/policy/test1/Test1a.java ! test/tools/javac/policy/test2/Test.java ! test/tools/javac/processing/model/util/elements/Foo.java ! test/tools/javac/rawDiags/Note.java ! test/tools/javac/tree/TreeKindTest.java ! test/tools/javac/typeAnnotations/newlocations/BasicTest.java ! test/tools/javac/varargs/T6746184.java ! test/tools/javac/varargs/warning/Warn1.java ! test/tools/javadoc/T4994049/FileWithTabs.java ! test/tools/javadoc/T4994049/T4994049.java ! test/tools/javap/T6715251.java ! test/tools/javap/T6715753.java ! test/tools/javap/T6729471.java ! test/tools/javap/T6868539.java Changeset: 4b0560c72b52 Author: cl Date: 2011-01-06 20:10 -0800 URL: http://hg.openjdk.java.net/jigsaw/jigsaw/langtools/rev/4b0560c72b52 Added tag jdk7-b124 for changeset 4868a36f6fd8 ! .hgtags Changeset: 45828a8ba371 Author: mchung Date: 2011-01-11 15:10 -0800 URL: http://hg.openjdk.java.net/jigsaw/jigsaw/langtools/rev/45828a8ba371 Merge ! .hgtags ! make/build.properties ! src/share/classes/com/sun/source/tree/Tree.java ! src/share/classes/com/sun/source/tree/TreeVisitor.java ! src/share/classes/com/sun/source/util/SimpleTreeVisitor.java ! src/share/classes/com/sun/source/util/TreeScanner.java - src/share/classes/com/sun/tools/apt/main/JavaCompiler.java ! src/share/classes/com/sun/tools/classfile/ClassWriter.java - src/share/classes/com/sun/tools/doclets/formats/html/StylesheetWriter.java - src/share/classes/com/sun/tools/doclets/internal/toolkit/util/SourceToHTMLConverter.java ! src/share/classes/com/sun/tools/javac/code/Flags.java ! src/share/classes/com/sun/tools/javac/code/Kinds.java ! src/share/classes/com/sun/tools/javac/code/Scope.java ! src/share/classes/com/sun/tools/javac/code/Source.java ! src/share/classes/com/sun/tools/javac/code/Symbol.java ! src/share/classes/com/sun/tools/javac/code/Symtab.java ! src/share/classes/com/sun/tools/javac/code/Type.java ! src/share/classes/com/sun/tools/javac/code/Types.java ! src/share/classes/com/sun/tools/javac/comp/Attr.java ! src/share/classes/com/sun/tools/javac/comp/Check.java ! src/share/classes/com/sun/tools/javac/comp/Enter.java ! src/share/classes/com/sun/tools/javac/comp/Flow.java ! src/share/classes/com/sun/tools/javac/comp/Lower.java ! src/share/classes/com/sun/tools/javac/comp/MemberEnter.java ! src/share/classes/com/sun/tools/javac/comp/Resolve.java ! src/share/classes/com/sun/tools/javac/file/JavacFileManager.java ! src/share/classes/com/sun/tools/javac/file/Paths.java ! src/share/classes/com/sun/tools/javac/jvm/ClassReader.java ! src/share/classes/com/sun/tools/javac/jvm/ClassWriter.java ! src/share/classes/com/sun/tools/javac/jvm/Target.java ! src/share/classes/com/sun/tools/javac/main/JavaCompiler.java ! src/share/classes/com/sun/tools/javac/main/Main.java ! src/share/classes/com/sun/tools/javac/main/OptionName.java ! src/share/classes/com/sun/tools/javac/main/RecognizedOptions.java ! src/share/classes/com/sun/tools/javac/model/JavacElements.java ! src/share/classes/com/sun/tools/javac/parser/JavacParser.java ! src/share/classes/com/sun/tools/javac/parser/Keywords.java ! src/share/classes/com/sun/tools/javac/parser/Scanner.java ! src/share/classes/com/sun/tools/javac/resources/compiler.properties ! src/share/classes/com/sun/tools/javac/resources/javac.properties ! src/share/classes/com/sun/tools/javac/tree/JCTree.java ! src/share/classes/com/sun/tools/javac/tree/Pretty.java ! src/share/classes/com/sun/tools/javac/tree/TreeCopier.java ! src/share/classes/com/sun/tools/javac/tree/TreeInfo.java ! src/share/classes/com/sun/tools/javac/tree/TreeMaker.java ! src/share/classes/com/sun/tools/javac/tree/TreeScanner.java ! src/share/classes/com/sun/tools/javac/tree/TreeTranslator.java ! src/share/classes/com/sun/tools/javac/util/Names.java ! src/share/classes/com/sun/tools/javap/AttributeWriter.java ! test/tools/javac/T6705935.java - test/tools/javac/TryWithResources/ArmLint.java - test/tools/javac/TryWithResources/ArmLint.out - test/tools/javac/diags/examples/EmptyBytecodeIdent.java - test/tools/javac/diags/examples/IllegalBytecodeIdentChar.java - test/tools/javac/diags/examples/MulticatchMustBeFinal.java - test/tools/javac/diags/examples/UnclosedBytecodeIdent.java - test/tools/javac/diags/examples/UnsupportedExoticID.java - test/tools/javac/diags/examples/VarargsFilename.java - test/tools/javac/diags/examples/VarargsFilenameAdditional.java - test/tools/javac/diags/examples/VarargsPlural/VarargsFilename.java - test/tools/javac/diags/examples/VarargsPlural/VarargsPlural.java - test/tools/javac/diags/examples/VarargsPluralAdditional/VarargsFilename.java - test/tools/javac/diags/examples/VarargsPluralAdditional/VarargsPlural.java - test/tools/javac/diags/examples/VarargsPluralAdditional/VarargsPluralAdditional.java ! test/tools/javac/nio/compileTest/CompileTest.java - test/tools/javac/quid/QuotedIdent.java - test/tools/javac/quid/QuotedIdent2.java ! test/tools/javac/tree/TreeKindTest.java ! test/tools/javac/varargs/6730476/T6730476a.java ! test/tools/javap/T6729471.java From mandy.chung at oracle.com Tue Jan 11 16:13:22 2011 From: mandy.chung at oracle.com (Mandy Chung) Date: Tue, 11 Jan 2011 16:13:22 -0800 Subject: jps fix and test exclude list for jdk-module-image Message-ID: <4D2CF222.5080803@oracle.com> I am taking a pass at the regression test failures when running with jdk-module-image. My goal is to get all the test targets in a JPRT job to succeed with modules build (i.e. testing jdk-module-image) so that we can easily identify regressions with the jigsaw development and also with the periodic update with jdk 7 repositories. First batch of changes: http://cr.openjdk.java.net/~mchung/jigsaw/webrevs/jps-module-fix/ Summary of changes: 1. Add jdk_jigsaw in the jprt testset. 2. Add regression test failures in jdk/test/ModulesProblemList.txt to temporarily exclude them until the bugs are fixed. 3. Some minor cleanup in the class analyzer tool 4. Fix jps to print the correct information (main change in this webrev) and details below. A number of jps unit tests failed because jps (and a number of other jdk tools) now is launched in module mode. jps used to print the class name (e.g. sun.tools.jps.Jps). In module mode, jps now prints the module name e.g. 'jdk.tools at 7-ea'. The tests check if it shows jps itself by comparing the output. Jps also truncates the package name to show the class name in a short form and thus it shows 'tools at 7-ea' rather than the full module name. The fix involves changes in java launcher, hotspot VM and jps. 1. the java launcher will pass -Dsun.java.main to the VM. This property will be either the main class name or the module name being launched. 2. the VM adds two new jvmstat counters (sun.rt.javaMain and sun.rt.javaModule). 3. If an application is running in module mode (ie. non-empty sun.rt.javaModule), then jps will print the full module name even for the short form. jps -l option prints the long form that will show the full path of a class name. 4. If the application is a jdk tool (e.g. jps and jstat), it launches the 'jdk.tools' module and pass the main class name as the first argument [1] (that is the current workaround for multi entry point support). It's not as useful if jps just shows 'jdk.tools'. So in this case, jps will print the main class name of the tool instead of the module name. There is a jps RFE to support printing the classname of an applet or a webstart application. The -Dsun.java.main property can be extended for this purpose in the future. With the above changes, langtools_jtreg and jdk_jigsaw are the remaining test targets with failures. langtools_jtreg has about 8 failures jdk_jigsaw tests depend on gawk and cc compiler. I'll ask if we can get help to install gawk on all JPRT systems and deal with the compilation of the native library next. Anyone has cycle to review this? Mandy [1] http://mail.openjdk.java.net/pipermail/jigsaw-dev/2010-September/001118.html From sean.mullan at oracle.com Thu Jan 13 07:52:23 2011 From: sean.mullan at oracle.com (Sean Mullan) Date: Thu, 13 Jan 2011 10:52:23 -0500 Subject: Code review request for storing code signer info Message-ID: <4D2F1FB7.5010304@oracle.com> See http://cr.openjdk.java.net/~mullan/jigsaw/webrevs/jigsaw-certs/webrev.00/ This patch fixes two issues: 1) A signed module's code signer information (the signer's certificate chain and timestamp) is now stored as metadata rather than using serialization. This addresses Mark's code review comment that had been deferred: http://mail.openjdk.java.net/pipermail/jigsaw-dev/2010-June/001071.html 2) The signed-module.sh test failure has been fixed. This failure occurred because the cacerts keystore in the OpenJDK source repository is empty. A new system property has been introduced to allow you to override the cacerts file. Also, I moved the loading of the cacerts keystore into the PKCS7VerifierParameters class and changed the getTrustAnchors method to getTrustedCerts. Thanks, Sean From mandy.chung at oracle.com Thu Jan 13 12:30:35 2011 From: mandy.chung at oracle.com (Mandy Chung) Date: Thu, 13 Jan 2011 12:30:35 -0800 Subject: Code review request for storing code signer info In-Reply-To: <4D2F1FB7.5010304@oracle.com> References: <4D2F1FB7.5010304@oracle.com> Message-ID: <4D2F60EB.6010802@oracle.com> On 01/13/11 07:52, Sean Mullan wrote: > See > http://cr.openjdk.java.net/~mullan/jigsaw/webrevs/jigsaw-certs/webrev.00/ > org/openjdk/jigsaw/ModuleFileFormat.java line 1744-1746: I think synchronization may not be an issue here as module installation is done in a single thread. line 1843: jpkg takes the -k option. I wonder if jmod should also accept an alternative keystore location rather than using a system property to override it. Or it is a requirement to use the system-wise cacerts file? line 1855-1858: it would be good to use try-with-resources. test/org/openjdk/jigsaw/cli/jmod-signed.sh line 85: Should we test both with and without the --noverify option? The --noverify option was tested before this patch. Otherwise, looks good. Mandy From sean.mullan at oracle.com Fri Jan 14 08:33:27 2011 From: sean.mullan at oracle.com (Sean Mullan) Date: Fri, 14 Jan 2011 11:33:27 -0500 Subject: Code review request for storing code signer info In-Reply-To: <4D2F60EB.6010802@oracle.com> References: <4D2F1FB7.5010304@oracle.com> <4D2F60EB.6010802@oracle.com> Message-ID: <4D307AD7.3070801@oracle.com> On 1/13/11 3:30 PM, Mandy Chung wrote: > On 01/13/11 07:52, Sean Mullan wrote: >> See http://cr.openjdk.java.net/~mullan/jigsaw/webrevs/jigsaw-certs/webrev.00/ >> > > org/openjdk/jigsaw/ModuleFileFormat.java > line 1744-1746: I think synchronization may not be an issue here as module > installation is done in a single thread. Ok, I'll leave the code as is for now, but I'll add a code comment that we may need to synchronize this. There are actually several CertificateFactory objects instantiated at different layers of the code when verifying a signed module, so one of the things I also want to look at is whether it is possible to reduce that number and reuse the same CertificateFactory. > line 1843: > jpkg takes the -k option. I wonder if jmod should also accept an > alternative keystore location rather than using a system property to override > it. Or it is a requirement to use the system-wise cacerts file? It is not a requirement to use a system-wide cacerts file, but that should be the default in my opinion. I'm not thrilled about using a system property but I also don't want to necessarily clutter the command line tool with additional options that should be rarely used. Have we given any thought as to whether we will add some sort of configuration properties file to allow default settings to be overridden? There are other security defaults that will likely need to be overriden, such as revocation checking settings. > line 1855-1858: it would be good to use try-with-resources. Ah, you mean the Project Coin enhancement? Is there an example of code that uses this already that you can point me to? > test/org/openjdk/jigsaw/cli/jmod-signed.sh > line 85: Should we test both with and without the --noverify option? The > --noverify option was tested before this patch. Sure, I can add that back. --Sean > > Otherwise, looks good. > > Mandy > From mandy.chung at oracle.com Fri Jan 14 11:09:44 2011 From: mandy.chung at oracle.com (Mandy Chung) Date: Fri, 14 Jan 2011 11:09:44 -0800 Subject: Code review request for storing code signer info In-Reply-To: <4D307AD7.3070801@oracle.com> References: <4D2F1FB7.5010304@oracle.com> <4D2F60EB.6010802@oracle.com> <4D307AD7.3070801@oracle.com> Message-ID: <4D309F78.5070403@oracle.com> On 1/14/11 8:33 AM, Sean Mullan wrote: > On 1/13/11 3:30 PM, Mandy Chung wrote: >> On 01/13/11 07:52, Sean Mullan wrote: >>> See >>> http://cr.openjdk.java.net/~mullan/jigsaw/webrevs/jigsaw-certs/webrev.00/ >>> >> >> org/openjdk/jigsaw/ModuleFileFormat.java >> line 1744-1746: I think synchronization may not be an issue here as >> module >> installation is done in a single thread. > > Ok, I'll leave the code as is for now, but I'll add a code comment > that we may need to synchronize this. There are actually several > CertificateFactory objects instantiated at different layers of the > code when verifying a signed module, so one of the things I also want > to look at is whether it is possible to reduce that number and reuse > the same CertificateFactory. > >> line 1843: >> jpkg takes the -k option. I wonder if jmod should also >> accept an >> alternative keystore location rather than using a system property to >> override >> it. Or it is a requirement to use the system-wise cacerts file? > > It is not a requirement to use a system-wide cacerts file, but that > should be the default in my opinion. > > I'm not thrilled about using a system property but I also don't want > to necessarily clutter the command line tool with additional options > that should be rarely used. > I agree that the system-wide cacerts should continue to be the default. As it rarely needs to override the location of cacerts file, a system property for the testing purpose would suffice. > Have we given any thought as to whether we will add some sort of > configuration properties file to allow default settings to be > overridden? There are other security defaults that will likely need to > be overriden, such as revocation checking settings. > In JRE, there is a $JAVA_HOME/lib/security/java.security properties file that allows the default security settings to be overriden. Do you mean whether we will add a new configuration properties file for the base module to use (replacing java.security one?)? We haven't thought about that but I think it's something we should consider. Reading a properties file for configuration has startup impact. I found that some existing properties files in the JRE such as logging.properties incur unnecessary startup cost as most applications use the default configuration. Generally if we add a new configuration properties file, I would propose to build in the default configuration in the runtime and we will just ship a template file (different name as the actual configuration file so that the file only exists if it's not the default). >> line 1855-1858: it would be good to use try-with-resources. > > Ah, you mean the Project Coin enhancement? Is there an example of code > that uses this already that you can point me to? > I don't know off hand but the specification is here: http://blogs.sun.com/darcy/entry/project_coin_updated_arm_spec I believe Stuart will modernize the JDK to use try-with-resources for JDK 7 after he finishes the diamond conversion. Mandy From sean.mullan at oracle.com Fri Jan 14 12:26:53 2011 From: sean.mullan at oracle.com (Sean Mullan) Date: Fri, 14 Jan 2011 15:26:53 -0500 Subject: Code review request for storing code signer info In-Reply-To: <4D309F78.5070403@oracle.com> References: <4D2F1FB7.5010304@oracle.com> <4D2F60EB.6010802@oracle.com> <4D307AD7.3070801@oracle.com> <4D309F78.5070403@oracle.com> Message-ID: <4D30B18D.80406@oracle.com> On 1/14/11 2:09 PM, Mandy Chung wrote: >> Have we given any thought as to whether we will add some sort of configuration >> properties file to allow default settings to be overridden? There are other >> security defaults that will likely need to be overriden, such as revocation >> checking settings. >> > In JRE, there is a $JAVA_HOME/lib/security/java.security properties file that > allows the default security settings to be overriden. Do you mean whether we > will add a new configuration properties file for the base module to use > (replacing java.security one?)? Yes and no. We could leverage the java.security properties file but that has the unfortunate outstanding issue that any modifications will be lost when you update the JRE. I was thinking more along the lines of a general modules property file for overriding various settings. Something similar to the property files that you can configure for Java Plugin/WebStart: http://download.oracle.com/javase/7/docs/technotes/guides/deployment/deployment-guide/properties.html > We haven't thought about that but I think it's > something we should consider. > > Reading a properties file for configuration has startup impact. I found that > some existing properties files in the JRE such as logging.properties incur > unnecessary startup cost as most applications use the default configuration. > Generally if we add a new configuration properties file, I would propose to > build in the default configuration in the runtime and we will just ship a > template file (different name as the actual configuration file so that the file > only exists if it's not the default). Ideally these properties would only be read when you are installing/verifying a module which would have less of a noticeable performance impact. Anyway, perhaps I'm thinking too far ahead. I think we should defer this issue and I will just use a system property for now. > >>> line 1855-1858: it would be good to use try-with-resources. >> >> Ah, you mean the Project Coin enhancement? Is there an example of code that >> uses this already that you can point me to? >> > > I don't know off hand but the specification is here: > http://blogs.sun.com/darcy/entry/project_coin_updated_arm_spec > > I believe Stuart will modernize the JDK to use try-with-resources for JDK 7 > after he finishes the diamond conversion. I suggest we wait until Stuart makes some progress on that as we will have useful code examples to work off of. --Sean From Alan.Bateman at oracle.com Wed Jan 19 06:59:59 2011 From: Alan.Bateman at oracle.com (Alan Bateman) Date: Wed, 19 Jan 2011 14:59:59 +0000 Subject: jps fix and test exclude list for jdk-module-image In-Reply-To: <4D2CF222.5080803@oracle.com> References: <4D2CF222.5080803@oracle.com> Message-ID: <4D36FC6F.7000506@oracle.com> Mandy Chung wrote: > I am taking a pass at the regression test failures when running with > jdk-module-image. My goal is to get all the test targets in a JPRT > job to succeed with modules build (i.e. testing jdk-module-image) so > that we can easily identify regressions with the jigsaw development > and also with the periodic update with jdk 7 repositories. > > First batch of changes: > http://cr.openjdk.java.net/~mchung/jigsaw/webrevs/jps-module-fix/ > > Summary of changes: > 1. Add jdk_jigsaw in the jprt testset. > 2. Add regression test failures in jdk/test/ModulesProblemList.txt to > temporarily exclude them until the bugs are fixed. > 3. Some minor cleanup in the class analyzer tool > 4. Fix jps to print the correct information (main change in this > webrev) and details below. > > A number of jps unit tests failed because jps (and a number of other > jdk tools) now is launched in module mode. jps used to print the > class name (e.g. sun.tools.jps.Jps). In module mode, jps now prints > the module name e.g. 'jdk.tools at 7-ea'. The tests check if it shows > jps itself by comparing the output. Jps also truncates the package > name to show the class name in a short form and thus it shows > 'tools at 7-ea' rather than the full module name. > > The fix involves changes in java launcher, hotspot VM and jps. > 1. the java launcher will pass -Dsun.java.main to the VM. This > property will be either the main class name or the module name being > launched. > 2. the VM adds two new jvmstat counters (sun.rt.javaMain and > sun.rt.javaModule). > 3. If an application is running in module mode (ie. non-empty > sun.rt.javaModule), then jps will print the full module name even for > the short form. jps -l option prints the long form that will show the > full path of a class name. > 4. If the application is a jdk tool (e.g. jps and jstat), it launches > the 'jdk.tools' module and pass the main class name as the first > argument [1] (that is the current workaround for multi entry point > support). It's not as useful if jps just shows 'jdk.tools'. So in > this case, jps will print the main class name of the tool instead of > the module name. > > There is a jps RFE to support printing the classname of an applet or a > webstart application. The -Dsun.java.main property can be extended > for this purpose in the future. > > With the above changes, langtools_jtreg and jdk_jigsaw are the > remaining test targets with failures. > langtools_jtreg has about 8 failures > jdk_jigsaw tests depend on gawk and cc compiler. I'll ask if we > can get help to install gawk on all JPRT systems and deal with the > compilation of the native library next. > > Anyone has cycle to review this? > > Mandy > > [1] > http://mail.openjdk.java.net/pipermail/jigsaw-dev/2010-September/001118.html > > Apologies for the late review, but I finally got to this. The addition of the jdk_jigsaw tests looks good but it's not clear to me why the jdk_rmi batch is being added to JDK_TEST_LIST (it's also on JDK_TEST_LIST2, the batches that require a display for some reason). I wonder if this is something we should get sorted out upstream as the jdk_rmi batch is not run by default (to my knowledge). Also you've added a few tests to the problem list: 85 java/nio/channels/FileChannel/ClosedByInterrupt.java generic-all 86 java/nio/channels/SocketChannel/AdaptSocket.java linux-x64 87 java/nio/channels/SocketChannel/Connect.java linux-x64 88 java/nio/MappedByteBuffer/Force.java windows-i586 In the case of java/nio/channels/FileChannel/ClosedByInterrupt.java, I will guess that jdk and langtools weren't in sync at the time of the test run. I can't tell why the next two are on the list. In the case of java/nio/MappedByteBuffer/Force.java I assume it's the clean-up issue we have on Windows where file mappings can remain for a period after the process terminates. This isn't technically a test bug but I have created 7012823 to track looking for ideas on how to avoid these false failures. You've also added a few RMI tests to the list: 100 # Need further investigation 101 # TestFailedException: TEST FAILED: could not create registry 102 sun/rmi/runtime/Log/checkLogging/CheckLogStreams.java solaris-all 103 sun/rmi/runtime/Log/checkLogging/CheckLogging.java solaris-all 104 105 java/rmi/transport/dgcDeadLock/DGCDeadLock.java solaris-all I guess we aren't seeing these upstream because the jdk_rmi batch isn't run (as I mentioned above). The updates to the class analyzer look fine to me. Amusing to see application.vendor=mchung :-) The changes to get jps to print the correct information mostly looks okay to me. Some of the code in the launcher is starting to get tricky with the tools running in module mode. A small comment is that it would be nice if SetJavaMainProp didn't use sprintf. On the jvmstat counters, should we skip create the javaModule counter if not set? In MonitoredVmUtil.java, you're using "sm" as the StringMonitor in a few places that a bit inconsistent with the existing code. Should it be javaModule instead? That's all I have. -Alan. From mandy.chung at oracle.com Wed Jan 19 08:49:26 2011 From: mandy.chung at oracle.com (Mandy Chung) Date: Wed, 19 Jan 2011 08:49:26 -0800 Subject: jps fix and test exclude list for jdk-module-image In-Reply-To: <4D36FC6F.7000506@oracle.com> References: <4D2CF222.5080803@oracle.com> <4D36FC6F.7000506@oracle.com> Message-ID: <4D371616.9090201@oracle.com> On 1/19/11 6:59 AM, Alan Bateman wrote: > > Apologies for the late review, but I finally got to this. > No problem, thanks for the review. > The addition of the jdk_jigsaw tests looks good but it's not clear to > me why the jdk_rmi batch is being added to JDK_TEST_LIST (it's also on > JDK_TEST_LIST2, the batches that require a display for some reason). I > wonder if this is something we should get sorted out upstream as the > jdk_rmi batch is not run by default (to my knowledge). > The addition of the jdk_rmi tests was temporary for my own testing that I missed to take it out. I'll take it out. That was added to workaround that when I used jprt -testset all option, the JDK_TEST_LIST2 test jobs just exit. It's on my list to investigate. > Also you've added a few tests to the problem list: > The problem list is specific to modules build (i.e. testing jdk-module-image). I'm going to sync with jdk 7 and I will update this list or get them sorted out upstream if it's an issue in JDK 7. > 85 java/nio/channels/FileChannel/ClosedByInterrupt.java generic-all > 86 java/nio/channels/SocketChannel/AdaptSocket.java linux-x64 > 87 java/nio/channels/SocketChannel/Connect.java linux-x64 > 88 java/nio/MappedByteBuffer/Force.java windows-i586 > > In the case of java/nio/channels/FileChannel/ClosedByInterrupt.java, I > will guess that jdk and langtools weren't in sync at the time of the > test run. I can't tell why the next two are on the list. In the case > of java/nio/MappedByteBuffer/Force.java I assume it's the clean-up > issue we have on Windows where file mappings can remain for a period > after the process terminates. This isn't technically a test bug but I > have created 7012823 to track looking for ideas on how to avoid these > false failures. > > You've also added a few RMI tests to the list: > > 100 # Need further investigation > 101 # TestFailedException: TEST FAILED: could not create registry > 102 sun/rmi/runtime/Log/checkLogging/CheckLogStreams.java solaris-all > 103 sun/rmi/runtime/Log/checkLogging/CheckLogging.java solaris-all > 104 > 105 java/rmi/transport/dgcDeadLock/DGCDeadLock.java solaris-all > > I guess we aren't seeing these upstream because the jdk_rmi batch > isn't run (as I mentioned above). > > The updates to the class analyzer look fine to me. Amusing to see > application.vendor=mchung :-) > > The changes to get jps to print the correct information mostly looks > okay to me. Some of the code in the launcher is starting to get tricky > with the tools running in module mode. > Yeah, it's starting to get tricky and some of the code can be removed when we support multiple entry points. > A small comment is that it would be nice if SetJavaMainProp didn't use > sprintf. > I'll fix it (thanks for catching it). > On the jvmstat counters, should we skip create the javaModule counter > if not set? > I was thinking if there might be a need to determine if the application is running in a modular JDK and the presence of the javaModule counter would be an indication. Given it's unclear if that is needed, I will skip creating it if not set for now. > In MonitoredVmUtil.java, you're using "sm" as the StringMonitor in a > few places that a bit inconsistent with the existing code. Should it > be javaModule instead? > Will clean that up. > That's all I have. > Thanks Mandy From kelly.ohair at oracle.com Wed Jan 19 09:37:22 2011 From: kelly.ohair at oracle.com (Kelly O'Hair) Date: Wed, 19 Jan 2011 09:37:22 -0800 Subject: jps fix and test exclude list for jdk-module-image In-Reply-To: <4D371616.9090201@oracle.com> References: <4D2CF222.5080803@oracle.com> <4D36FC6F.7000506@oracle.com> <4D371616.9090201@oracle.com> Message-ID: <4D8E865F-CCF9-4035-A529-38420909D11F@oracle.com> On Jan 19, 2011, at 8:49 AM, Mandy Chung wrote: > On 1/19/11 6:59 AM, Alan Bateman wrote: >> >> Apologies for the late review, but I finally got to this. >> > No problem, thanks for the review. > >> The addition of the jdk_jigsaw tests looks good but it's not clear >> to me why the jdk_rmi batch is being added to JDK_TEST_LIST (it's >> also on JDK_TEST_LIST2, the batches that require a display for some >> reason). I wonder if this is something we should get sorted out >> upstream as the jdk_rmi batch is not run by default (to my >> knowledge). >> > > The addition of the jdk_rmi tests was temporary for my own testing > that I missed to take it out. I'll take it out. That was added to > workaround that when I used jprt -testset all option, the > JDK_TEST_LIST2 test jobs just exit. It's on my list to investigate. The 3 test batches jdk_rmi, jdk_awt, and jdk_swing are not large sets and have generally not been run by default much. They all suffer from needing a DISPLAY set on Linux/Solaris, but there are a few in jdk_misc that need a DISPLAY set too, but don't do much with it. Originally I did not add these 3 to any default list because of the DISPLAY need, but in particular some of these tests (maybe it was in jdk_awt) seem to change the window manager and leave it changed. To allow for this, in JPRT, each job gets a unique vnc session and DISPLAY so the tests can trash the DISPLAY and it won't impact the next job. So these tests could probably be run by default now, but since we haven't run them much to this point, we don't have much data on how reliable these tests are. Just be warned that they may change the way your windows are managed, like click to type or follow focus. The more we use the tests, the more we find out how stable they are, we fix or destroy, and then they stabilize. ;^) Keep in mind that some of these test batches run with -samevm and some do not. Thank you for doing this for the tests. Solid and predictable tests are always a tremendous value to a project. -kto From mandy.chung at oracle.com Wed Jan 19 16:00:56 2011 From: mandy.chung at oracle.com (mandy.chung at oracle.com) Date: Thu, 20 Jan 2011 00:00:56 +0000 Subject: hg: jigsaw/jigsaw: Add jdk_jigsaw to the test target Message-ID: <20110120000056.BE14647F76@hg.openjdk.java.net> Changeset: b10d6d79432e Author: mchung Date: 2011-01-19 15:57 -0800 URL: http://hg.openjdk.java.net/jigsaw/jigsaw/rev/b10d6d79432e Add jdk_jigsaw to the test target ! make/jprt.properties ! test/Makefile From mandy.chung at oracle.com Wed Jan 19 16:00:26 2011 From: mandy.chung at oracle.com (mandy.chung at oracle.com) Date: Thu, 20 Jan 2011 00:00:26 +0000 Subject: hg: jigsaw/jigsaw/jdk: module-aware jps and exclude tests in ModulesProblemList.txt Message-ID: <20110120000058.162D647F79@hg.openjdk.java.net> Changeset: cfc5509c33c4 Author: mchung Date: 2011-01-19 15:59 -0800 URL: http://hg.openjdk.java.net/jigsaw/jigsaw/jdk/rev/cfc5509c33c4 module-aware jps and exclude tests in ModulesProblemList.txt ! make/modules/Makefile ! make/tools/classanalyzer/build.xml ! make/tools/classanalyzer/nbproject/project.properties ! make/tools/classanalyzer/src/com/sun/classanalyzer/ClassAnalyzer.java ! make/tools/classanalyzer/src/com/sun/classanalyzer/Module.java ! make/tools/classanalyzer/src/com/sun/classanalyzer/PlatformModuleBuilder.java ! src/share/bin/java.c ! src/share/bin/java.h ! src/share/classes/sun/jvmstat/monitor/MonitoredVmUtil.java ! test/Makefile ! test/ModulesProblemList.txt From mandy.chung at oracle.com Wed Jan 19 16:01:08 2011 From: mandy.chung at oracle.com (mandy.chung at oracle.com) Date: Thu, 20 Jan 2011 00:01:08 +0000 Subject: hg: jigsaw/jigsaw/hotspot: Add javaMain and javaModule jvmstat counter for jps to be module-aware Message-ID: <20110120000114.4FAFD47F7C@hg.openjdk.java.net> Changeset: 39bd484345f0 Author: mchung Date: 2011-01-19 15:58 -0800 URL: http://hg.openjdk.java.net/jigsaw/jigsaw/hotspot/rev/39bd484345f0 Add javaMain and javaModule jvmstat counter for jps to be module-aware ! src/share/vm/runtime/arguments.cpp ! src/share/vm/runtime/arguments.hpp ! src/share/vm/runtime/statSampler.cpp From sean.mullan at oracle.com Thu Jan 27 12:05:47 2011 From: sean.mullan at oracle.com (sean.mullan at oracle.com) Date: Thu, 27 Jan 2011 20:05:47 +0000 Subject: hg: jigsaw/jigsaw/jdk: 4 new changesets Message-ID: <20110127200702.681D3471C4@hg.openjdk.java.net> Changeset: d30255af495b Author: mullan Date: 2011-01-26 15:38 -0500 URL: http://hg.openjdk.java.net/jigsaw/jigsaw/jdk/rev/d30255af495b Store signed module's code signers as metadata rather than serialized form. Fix signed-module.sh test failure by adding new system property (org.openjdk.system.security.cacerts) to allow you to override the cacerts file. Reviewed-by: mchung ! src/share/classes/org/openjdk/jigsaw/FileConstants.java ! src/share/classes/org/openjdk/jigsaw/Files.java ! src/share/classes/org/openjdk/jigsaw/Loader.java ! src/share/classes/org/openjdk/jigsaw/ModuleFileFormat.java ! src/share/classes/org/openjdk/jigsaw/ModuleFileVerifier.java ! src/share/classes/org/openjdk/jigsaw/SimpleLibrary.java ! test/org/openjdk/jigsaw/cli/ModuleFormatTest01.java ! test/org/openjdk/jigsaw/cli/ModuleFormatTest01.sh ! test/org/openjdk/jigsaw/cli/jmod-signed.sh - test/org/openjdk/jigsaw/cli/signed-module.policy ! test/org/openjdk/jigsaw/cli/signed-module.sh Changeset: 7030656ede3e Author: mullan Date: 2011-01-26 15:56 -0500 URL: http://hg.openjdk.java.net/jigsaw/jigsaw/jdk/rev/7030656ede3e Merge - src/share/classes/sun/net/httpserver/SelectorCache.java - src/share/classes/sun/security/krb5/KrbKdcReq.java - src/share/classes/sun/security/krb5/internal/TCPClient.java - src/share/classes/sun/security/krb5/internal/UDPClient.java - src/solaris/classes/sun/net/www/protocol/http/NTLMAuthentication.java Changeset: 6a15d98a8a8e Author: mullan Date: 2011-01-26 16:59 -0500 URL: http://hg.openjdk.java.net/jigsaw/jigsaw/jdk/rev/6a15d98a8a8e Merge ! test/org/openjdk/jigsaw/cli/ModuleFormatTest01.java ! test/org/openjdk/jigsaw/cli/jmod-signed.sh Changeset: b11a701e48be Author: mullan Date: 2011-01-27 13:59 -0500 URL: http://hg.openjdk.java.net/jigsaw/jigsaw/jdk/rev/b11a701e48be Test both with and without the jmod install --noverify option. Reviewed-by: mchung ! test/org/openjdk/jigsaw/cli/jmod-signed.sh