jps fix and test exclude list for jdk-module-image
Kelly O'Hair
kelly.ohair at oracle.com
Wed Jan 19 09:37:22 PST 2011
On Jan 19, 2011, at 8:49 AM, Mandy Chung wrote:
> On 1/19/11 6:59 AM, Alan Bateman wrote:
>>
>> Apologies for the late review, but I finally got to this.
>>
> No problem, thanks for the review.
>
>> The addition of the jdk_jigsaw tests looks good but it's not clear
>> to me why the jdk_rmi batch is being added to JDK_TEST_LIST (it's
>> also on JDK_TEST_LIST2, the batches that require a display for some
>> reason). I wonder if this is something we should get sorted out
>> upstream as the jdk_rmi batch is not run by default (to my
>> knowledge).
>>
>
> The addition of the jdk_rmi tests was temporary for my own testing
> that I missed to take it out. I'll take it out. That was added to
> workaround that when I used jprt -testset all option, the
> JDK_TEST_LIST2 test jobs just exit. It's on my list to investigate.
The 3 test batches jdk_rmi, jdk_awt, and jdk_swing are not large sets
and have generally not been
run by default much. They all suffer from needing a DISPLAY set on
Linux/Solaris, but there are a few
in jdk_misc that need a DISPLAY set too, but don't do much with it.
Originally I did not add these 3 to any default list because of the
DISPLAY need, but in particular some
of these tests (maybe it was in jdk_awt) seem to change the window
manager and leave it changed.
To allow for this, in JPRT, each job gets a unique vnc session and
DISPLAY so the tests can trash the DISPLAY and
it won't impact the next job. So these tests could probably be run by
default now, but since we haven't
run them much to this point, we don't have much data on how reliable
these tests are.
Just be warned that they may change the way your windows are managed,
like click to type or follow focus.
The more we use the tests, the more we find out how stable they are,
we fix or destroy, and then they stabilize. ;^)
Keep in mind that some of these test batches run with -samevm and some
do not.
Thank you for doing this for the tests. Solid and predictable tests
are always a tremendous value to a project.
<snip>
-kto
More information about the jigsaw-dev
mailing list