Patch for jigsaw tests to run on all platforms

Mandy Chung mandy.chung at oracle.com
Mon Mar 14 12:07:03 PDT 2011


  On 3/14/11 11:47 AM, Alan Bateman wrote:
> Mandy Chung wrote:
>>  This patch fixes the jigsaw tests to run on all platforms and also
>> replace calls to the java.io.File.renameTo method with
>> java.nio.file.Files.move method since on windows File.renameTo
>> fails if the target file exists.
>>
>> Webrev at:
>>   http://cr.openjdk.java.net/~mchung/jigsaw/webrevs/jigsaw-tests.00/
> I went through the change and looks okay to me.
>
> I'm not sure what to say about test/org/openjdk/jigsaw/hello-native.sh 
> as we can't assume a C compiler on the test machine and checking in 
> pre-build shared libraries is frowned upon.
>

Yeah... I know...  probably we have to rely on SQE tests to cover the 
testing for native libraries.  Right now all jprt machines have the C 
compilers installed and we can temporarily leave with this dependency 
until such functionality is covered in other test harness.

> I'll leave the JPRT updates to Kelly but I think you should be able to 
> run the Jigsaw tests already with -otests '.*jdk_jigsaw.*'
>

There was some issue with -otests option some time ago that didn't 
exclude the default test targets.
  We had to use -etests as a workaround at that time.  I just tried dry 
run with the -otests option and looks like Kelly fixed that.  I will 
take out the jprt.properties change.

Mandy



More information about the jigsaw-dev mailing list