Please review: Signed Modular JAR file support

Sean Mullan sean.mullan at oracle.com
Tue May 24 10:42:43 PDT 2011


On 5/24/11 1:02 PM, Mandy Chung wrote:
> Sean,
>
>>
>> Webrev at:
>> http://cr.openjdk.java.net/~mullan/jigsaw/webrevs/signed-modular-jars/webrev.00/
>
>
> The change looks fine to me. As for the test, is it worth (if feasible) adding
> the multiple signers case?

I will test it manually.

But if it is ok with you, I would like to hold off on adding a test for that for 
now, since there are a lot of other test cases I would like to add, for example 
there are no invalid test cases right now. I have a few more signed modules 
tasks to complete, and then I want to take a closer look at improving and adding 
more tests.

--Sean



More information about the jigsaw-dev mailing list