Compressing class files in the module library

[Chris Hegarty]

Thanks Alan, I also like the -z option.

One more minor comment on the code itself, otherwise looks fine.

  - with the changes in ClassInfo the given InputStream is no longer
    closed. Was this intentional?

-Chris.

On 14/11/2011 09:24, Alan Bateman wrote:
> On 10/11/2011 22:21, Mandy Chung wrote:
>>
>> I agree with Chris that -9 gives the impression that it supports a
>> range of compression level (0-9). If that's what we support in the
>> future, -9 is a good option. Regarding Chris's question on the Pack200
>> compression level, the spec for Pack200.Packer.EFFORT says:
>> Level 1 may produce somewhat larger size and faster compression speed,
>> while level 9 will take much longer but may produce better compression.
>>
>> The use of "may" which means it's not a guarantee. It does accept to
>> specify a compression level from 0-9.
>>
>> Other than -0...-9, would "-z" be a good alternative? i.e. jmod create
>> -z -L mlib
> -z is a good idea, I see Mark likes it too. I've updated the webrev [1].
> I've left it as a module create time option for now. If we really need
> it on a per-module basis then we can add it later.
>
> -Alan
>
> [1] http://cr.openjdk.java.net/~alanb/ModuleLibraryCompression/webrev/