Review request: jpkg -m option takes both classes and resources
Mandy Chung
mandy.chung at oracle.com
Mon Nov 14 20:14:01 PST 2011
On 11/14/2011 11:14 AM, Alan Bateman wrote:
> On 14/11/2011 18:55, Mandy Chung wrote:
>>
>> I agree that the class names and the getInstance method should be
>> renamed. How about renaming the class names to
>> CompressorOutputStream and CompressedClassFileOutputStream and
>> renaming getInstance to newInstance?
> Yes, that would be better (alternatively CompressedClassOutputStream).
Rename done. I also changed the newInstance method to do the
compression before returning the compressed output stream instance (this
removes the call to the compress method from several callers).
Upated webrev:
http://cr.openjdk.java.net/~mchung/jigsaw/webrevs/jpkg-dash-r-option.01/
Mandy
More information about the jigsaw-dev
mailing list