Review request: jpkg -m option takes both classes and resources

[Dalibor Topic]

On 11/15/11 5:14 AM, Mandy Chung wrote:
> On 11/14/2011 11:14 AM, Alan Bateman wrote:
>> On 14/11/2011 18:55, Mandy Chung wrote:
>>>
>>> I agree that the class names and the getInstance method should be renamed.  How about renaming the class names to CompressorOutputStream and CompressedClassFileOutputStream and renaming getInstance to newInstance?
>> Yes, that would be better (alternatively CompressedClassOutputStream).
> 
> Rename done.  I also changed the newInstance method to do the compression before returning the compressed output stream instance (this removes the call to the compress method from several callers).
> 
> Upated webrev:
>    http://cr.openjdk.java.net/~mchung/jigsaw/webrevs/jpkg-dash-r-option.01/


This is a very nice change! Do you plan eventually to factor out a module file reader as well?

cheers,
dalibor topic

-- 
Oracle <http://www.oracle.com>
Dalibor Topic | Java F/OSS Ambassador
Phone: +494023646738 <tel:+494023646738> | Mobile: +491772664192 <tel:+491772664192>
Oracle Java Platform Group

ORACLE Deutschland B.V. & Co. KG | Nagelsweg 55 | 20097 Hamburg

ORACLE Deutschland B.V. & Co. KG
Hauptverwaltung: Riesstr. 25, D-80992 München
Registergericht: Amtsgericht München, HRA 95603

Komplementärin: ORACLE Deutschland Verwaltung B.V.
Hertogswetering 163/167, 3543 AS Utrecht, Niederlande
Handelsregister der Handelskammer Midden-Niederlande, Nr. 30143697
Geschäftsführer: Jürgen Kunz, Marcel van de Molen, Alexander van der Ven

Green Oracle <http://www.oracle.com/commitment> Oracle is committed to developing practices and products that help protect the environment