modules without classes

Peter Jensen peter.jensen at oracle.com
Wed Nov 30 11:02:19 PST 2011


Yes, fix worked for me, and it was also the only place I found.

On 11/30/11 10:25, Mandy Chung wrote:
> On 11/30/2011 10:17 AM, Alan Bateman wrote:
>>
>> Yes, it's the reindexing as it assumes that the classes file exist. 
>> Easily fixed with the attached and if you're okay with it then I'll 
>> push it today so that the empty jdk.* modules can be installed. I'll 
>> also check other areas in case we have similar assumptions (I found 
>> another in the --strip-debug work).
>>
>
> Thanks for fixing it.  I can help fix other issue if any.  I scanned 
> on SimpleLibrary and looks like reindexing is the only one.
>
>>
>> diff --git a/src/share/classes/org/openjdk/jigsaw/SimpleLibrary.java 
>> b/src/share/classes/org/openjdk/jigsaw/SimpleLibrary.java
>> --- a/src/share/classes/org/openjdk/jigsaw/SimpleLibrary.java
>> +++ b/src/share/classes/org/openjdk/jigsaw/SimpleLibrary.java
>> @@ -778,7 +778,7 @@
>>                          addToIndex(ClassInfo.read(f), ix);
>>                  }
>>              });
>> -        } else {
>> +        } else if (cd.isFile()) {
>>              FileInputStream fis = new FileInputStream(cd);
>>              ZipInputStream zis = new ZipInputStream(fis);
>>              ZipEntry ze;
>>
>>
>
> Thumbs up.
>
> Thanks
> Mandy




More information about the jigsaw-dev mailing list