Code Review Request for 6953295 and related changes to add keytool to jdk.tools.base

Sean Mullan sean.mullan at oracle.com
Thu Oct 6 09:02:06 PDT 2011


On 10/5/11 6:24 PM, Mandy Chung wrote:
> On 9/20/11 2:44 PM, Sean Mullan wrote:
>> New webrev:
>> http://cr.openjdk.java.net/~mullan/jigsaw/webrevs/6953295/webrev.01/
>>
>
> Looks good.
>
> BTW, while I'm merging the jdk8 repos with the jigsaw repos, I realize
> that the restructuring in the timestamping code you did back in April
> [1, 2] is also orthogonal to jigsaw. I think it'd be best to port that
> change to JDK 8 repo as other jdk8 changes are happening there and it
> will also help the merge. Would you be able to push that non-module
> related change to jdk8 as well?

Yes.

--Sean

>
> Thanks
> Mandy
>
> [1]
> http://mail.openjdk.java.net/pipermail/jigsaw-dev/2011-April/001239.html
> [2] http://hg.openjdk.java.net/jigsaw/jigsaw/jdk/rev/82c28137a816
>




More information about the jigsaw-dev mailing list