Code Review Request for 6953295 and related changes to add keytool to jdk.tools.base

[Sean Mullan]

On 10/5/11 10:19 PM, David Holmes wrote:
> There seem to be a lot of Java code changes in that webrev that seem
> unrelated to moving keytool ???

Not really. There is a bit of extra cleanup/dead-code removal in CR 
6953295 like removing sun.security.util.BigInt but everything else is 
necessary to move keytool and jarsigner to jdk.tools.base. Basically a 
bunch of classes that only jarsigner/keytool use were moved to different 
packages.

--Sean

>
> David
>
> On 6/10/2011 11:24 AM, Mandy Chung wrote:
>> On 9/20/11 2:44 PM, Sean Mullan wrote:
>>> New webrev:
>>> http://cr.openjdk.java.net/~mullan/jigsaw/webrevs/6953295/webrev.01/
>>>
>>
>> Looks good.
>>
>> BTW, while I'm merging the jdk8 repos with the jigsaw repos, I realize
>> that the restructuring in the timestamping code you did back in April
>> [1, 2] is also orthogonal to jigsaw. I think it'd be best to port that
>> change to JDK 8 repo as other jdk8 changes are happening there and it
>> will also help the merge. Would you be able to push that non-module
>> related change to jdk8 as well?
>>
>> Thanks
>> Mandy
>>
>> [1]
>> http://mail.openjdk.java.net/pipermail/jigsaw-dev/2011-April/001239.html
>> [2] http://hg.openjdk.java.net/jigsaw/jigsaw/jdk/rev/82c28137a816
>>