Code Review Request for 6953295 and related changes to add keytool to jdk.tools.base

Sean Mullan sean.mullan at oracle.com
Wed Sep 14 12:08:00 PDT 2011


Requesting review from Mandy and Max, others welcome.

CR: http://monaco.us.oracle.com/detail.jsf?cr=6953295
Webrev: http://cr.openjdk.java.net/~mullan/jigsaw/webrevs/6953295/webrev.00/

Additional notes to reviewers:

* I will push the non-module related changes to JDK 8 first. I wanted to first
make sure everything worked with the module changes.

* The following classes have been moved to the sun.security.pkcs10 package to
remove dependencies on the sun.jsse module:

sun.security.pkcs.PKCS10	
sun.security.pkcs.PKCS10Attribute
sun.security.pkcs.PKCS10Attributes

and these classes have been moved to the sun.security.tools package:

sun.security.x509.CertAndKeyGen
sun.security.util.PathList

The code is the same other than changes due to the package rename.

* The following classes have been removed since nothing in the JDK uses them:

sun.security.pkcs.EncodingException
sun.security.util.BigInt

The test/sun/security/util/BigInt/BigIntEqualsHashCode.java was also removed as
it is now N/A.

* Should I also include jarsigner in jdk.tools.base? I think it would be useful
for creating signed modular jars.

Thanks,
Sean




More information about the jigsaw-dev mailing list