Review Request: loading JCE providers using ServiceLoader

[Paul Sandoz]

On Aug 1, 2012, at 11:10 AM, Sean Mullan <sean.mullan at oracle.com> wrote:

> On 07/31/2012 12:26 AM, Paul Sandoz wrote:
>> Hi Sean,
>> 
>> The patch looks OK to me.
>> 
>> You have a redundant synchronised block in
>> Provider#doLoadProviderUsingServiceLoader you might want to remove.
> 
> The lock is on the ServiceLoader and I think that's still necessary. There's a ProviderConfig created for each Provider. It's possible there may be more than one thread accessing the ServiceLoader which is currently shared by all Providers.

Doh! yes, the reference is statically held.

Paul.