Review Request: loading JCE providers using ServiceLoader
Mandy Chung
mandy.chung at oracle.com
Fri Aug 10 16:46:27 PDT 2012
Hi Sean,
On 8/9/2012 8:14 AM, Sean Mullan wrote:
> Please review the 2nd webrev for my code changes to enable JCE providers to be
> registered and loaded as services using the ServiceLoader API:
>
> http://cr.openjdk.java.net/~mullan/jigsaw/webrevs/jce-service/webrev.01/
This looks good and cleaner with the refactoring you have done.
I agree we should move forward with this and address the open issues
next. One issue to add to the list is about the "java.security"
config file that lists the security provider classname. As Alan points
out, they are (likely) not exported in modules. Also all the Providers
available as services should be automatically added to the list of
registered providers (I think your patch only registers the ones
listed in java.security). These are related to the configured preference
order.
make/modules/modules.group
jdk.depconfig is intended for auto-generation of these
service dependency and implementation providing services
but META-INF/services/java.security.Provider doesn't exist.
That's why you need to declare these "provides service"
explicitly. Since we're going to check in module-info.java
in the source tree, I'm okay with this workaround.
It might worth adding a comment for that.
Most of the changes except Providers.ModuleProviderLoader are
refactoring. It's good to get that non-module-specific change
into jdk8 to reduce the number of changes in jigsaw/jigsaw to
carry that would help avoid merge issues. It's fine to push
that to jdk8 after this gets into jigsaw/jigsaw - whichever
is convenient.
Thanks
Mandy
More information about the jigsaw-dev
mailing list