Jigsaw classpath mode support

[Alan Bateman]

On 07/08/2012 18:47, Mandy Chung wrote:
> I have implemented the "classpath mode" support running on
> a module image.
>
> Webrev:
>   http://cr.openjdk.java.net/~mchung/jigsaw/webrevs/classpath-mode.00/
I've finally got through all of this. Overall this is really good work.

A couple of comments/questions:

In ClassPathContext when you distribute the contexts to each loader then 
it may be more efficient to iterate over each loader's module list and 
invoke the configuration's getContextForModuleName to get the Context 
directly. Then distribute the remaining to the loader for the boot class 
path. I suspect that could be more efficient than all the nested contains.

One thing that I can't tell from the changes is the value of the 
sun.boot.module.classpath property. That might be clear once Karen 
publishes the hotspot changes. I ask because I can't tell if 
Package.SystemPackage.isPackageFromModule is right, meaning whether 
JVM_GetSystemPackage returns the value of sun.boot.module.classpath for 
packages in the system modules.

In Launcher. ExtClassLoader there is code to split the extension 
directory into the paths that come before and after the default 
location. I think I need help in understand why someof this is needed 
because if someone sets java.ext.dirs then it should be a complete override?

I agree with your idea in the mail to get this pushed and deal with any 
clean-up/comments in later changes, especially as the test results are 
good. The only thing is I assume it will need to go in with the HotSpot 
changes.

In terms of clean-up then I think CleanPathContext should be more 
efficient. There are also a few things in the sun.misc.Launcher code but 
they aren't urgent for now.

-Alan.