Test for service iteration when SCE occurs

Paul Sandoz paul.sandoz at oracle.com
Fri Aug 31 01:41:47 PDT 2012


On Aug 30, 2012, at 11:03 PM, Mandy Chung <mandy.chung at oracle.com> wrote:

> On 8/30/2012 3:02 AM, Paul Sandoz wrote:
>> I did some hacking (even modified tester.sh to support different separators) and tried to apply this to both iteration-error.sh and loader.sh but after a bit i stopped because it is proving extremely fragile.
>> 
>> That script does not process interfaces correctly, nor classes that implement or extend, nor interfaces/classes with generic type signatures. So i think we should update tester.sh separately to support alternative separators and be more robust processing classes/interface names, then update other tests as required.
> 
> Sorry for taking you to the wrong path.   Rather than updating tester.sh, it's probably time to write a test library to replace it, as Mark mentions earlier [1].
> 

+1.


>> --
>> 
>> I updated the webrev to include another service provider class that throws an exception to guarantee that iteration continues, as we currently make no guarantees on the order of iteration.
>> 
>> I also removed the unused type parameter from ServiceLoaderTest.
> 
> I have pushed the changeset for you.
> 

Thanks!

Paul.

> Mandy
> [1] http://mail.openjdk.java.net/pipermail/jigsaw-dev/2012-August/003142.html
> 






More information about the jigsaw-dev mailing list