Allow remote repository to be located via non-http URI

Chris Hegarty chris.hegarty at oracle.com
Tue Feb 7 03:05:52 PST 2012


This looks good.

One minor comment; Should the arg passed to add-repo, if the scheme is 
unspecified, be checked to see if it is a directory? Or maybe this isn't 
all that useful ( it may be a dir, but not a valid repository ). The 
error handling in SimpleLibrary$RepoList.add could be more robust to 
handle this by removing the repoDir ( and its contents ) and possibly 
decrementing the count?

Also (related) what is the point of appending the '/' in canonicalize? 
If the file url points to a file then it will not end in a '/', 
therefore it cannot be a valid repo, right? Should this be an error, or 
just handled as above?

-Chris.

On 02/ 6/12 06:19 PM, Alan Bateman wrote:
>
> The remote repository is currently limited to http. I've changed the
> implementation so that other URIs can now be used, in particular file
> URIs where the repository is on the file system. The webrev with the
> changes is here:
>
> http://cr.openjdk.java.net/~alanb/jigsaw-localrepos/webrev/
>
> Thanks,
> Alan.



More information about the jigsaw-dev mailing list