Spacebars are missed in ServiceDependence.toString()

Alexey Fedorov alexey.x.fedorov at oracle.com
Wed Feb 15 12:22:09 PST 2012


Thank you, Alan!

http://cr.openjdk.java.net/~alanb/jigsaw-services/webrev/src/share/classes/java/lang/module/ServiceDependence.java.udiff.html 
<http://cr.openjdk.java.net/%7Ealanb/jigsaw-services/webrev/src/share/classes/java/lang/module/ServiceDependence.java.udiff.html> 
-

that's exactly what I meant!

--
Have a good day,
Alexey

On 16-Feb-12 0:05, Alan Bateman wrote:
> On 15/02/2012 19:59, Alexey Fedorov wrote:
>> Hi all,
>>
>> I am playing with Jigsaw and found the following small bug: method 
>> ServiceDependence.toString() contains modifier without any spacebars 
>> between them.
>>
>> Set<Dependence.Modifier> modifiers = new 
>> HashSet<>(Arrays.asList(OPTIONAL, PUBLIC));
>> ServiceDependence sd = new ServiceDependence(modifiers, "my.service");
>>
>> sd.toString returns:
>>
>>> requires serviceoptionalpublic my.service
>>
>> but expected something like:
>>
>>> requires service optional public my.service
>>
>> Seems like small bug :)
> I noticed this too and it's fixed in the services implementation [1], 
> just not pushed yet.
>
> -Alan.
>
> [1] http://cr.openjdk.java.net/~alanb/jigsaw-services/webrev/




More information about the jigsaw-dev mailing list