runtime changes for services
Alan Bateman
Alan.Bateman at oracle.com
Tue Feb 21 09:43:00 PST 2012
On 20/02/2012 20:43, Mandy Chung wrote:
>
> Looks good.
>
> The Context.services() and serviceSuppliers() methods return a mutable
> map. I understand the current usages are read-only but is
> inconsistent with other getter methods that return a unmodifiable
> map. Probably you are thinking about performance - I think it's worth
> revisiting the immutability of this class and some other classes in
> the future.
Yes, I'm thinking about performance so I left this comment as a
reminder. I don't mind changing this to return immutable maps for now
but it is something we'll need to come back to.
-Alan
More information about the jigsaw-dev
mailing list