RFR: Some intermittent org/openjdk/jigsaw test failures.

Chris Hegarty chris.hegarty at oracle.com
Tue Feb 21 12:01:08 PST 2012


Here is a patch to resolve some of the intermittent failing 
org/openjdk/jigsaw tests. Mainly Windows!

1) test/org/openjdk/jigsaw/TrivialWebServer.java
    test/org/openjdk/jigsaw/_RemoteRepository.java

    org/openjdk/jigsaw/remrepo.sh and org/openjdk/jigsaw/repolist.sh
    fail intermittently, typically Windows, occasionally on Linux. There
    is a small issue in the handling of Last-Modified in the bundled test
    HTTP server. This header only supports the granularity of seconds.
    So, it may be possible that the files lastModified date be actually
    greater than that of when it is converted to the value passed in the
    header and then converted back to millis. The solution is to use
    seconds for comparison ( since this is the granularity of the
    header).

    Also a minor issue in _RemoteRepository.java where, since the
    granularity is seconds, the test should ensure that the updated
    catalog be "newer". sleep!!!

2) test/org/openjdk/jigsaw/cli/JpkgArgsTest.java

    Skip testIfFileArgIsNotReadable since File readability cannot be set
    to false in Windows

3) test/org/openjdk/jigsaw/tester.sh

    <Sigh> To get resource.sh, resolver.sh, hello-view.sh to run under
    MKS on Windows. The changes should be harmless on other platforms.

    Only support one main entry point per test. This is what we support
    anyway, just to limit the entry in the main file since it can cause
    problems when trying to put more in, hello-view.sh for example.
    Secondly, MKS puts a hs_histo file in the working dir and may be
    mistaken for a test when actually running <Sigh>

Webrev:

   http://cr.openjdk.java.net/~chegar/jigsaw/tests_webrev.00/webrev/

-Chris.



More information about the jigsaw-dev mailing list