native cmds and libs in the module library

[Chris Hegarty]

Here is an updated webrev incorporating the feedback I received.

http://cr.openjdk.java.net/~chegar/jigsaw/libbin_webrev.01/webrev/

1) '-natlibs' -> '--natlibs', '-natcmds' -> '--natcmds'
2) detect during 'jmod create' if a directory is creatable/writable
3) detect conflicts and rollback changes if there is a conflict
4) track files installed outside of the module directory

It would be nice to allow an override of files in the module libraries 
natlibs or natcmds directories if a newer version of the same module is 
installed. Currently this will fail due to a conflict on these files. 
This shouldn't be difficult to add later.

-Chris.

On 20/12/2011 13:22, Chris Hegarty wrote:
> On 12/20/11 01:14 PM, Alan Bateman wrote:
>> On 19/12/2011 16:23, Sean Mullan wrote:
>>> On most systems, you'll probably also run into file permission issues
>>> if you
>>> aren't superuser or an administrator. Is this something you are going
>>> to detect
>>> up-front and warn the user or will the command just fail when it
>>> tries to
>>> install the files?
>>>
>>> --Sean
>>>
>> If the "jmod create" command creates the bin and lib directories and it
>> fails then that gives us the error. If it doesn't create the directories
>> then it could emit a warning if they aren't writable. In any case, if
>> the install fails for any reason then it should rollback all changes.
>
> Right, I'm in the process of making this change. Currently we only
> remove the module directory, we need to track out of module content and
> remove it if necessary. This will hopefully be useful for a 'jmod
> remove' command in the future too.
>
> I was planning to use the same rollback strategy if a conflict, a native
> library or command already exists with the same name, occurs. I'm also
> incorporating your feedback from yesterday.
>
> -Chris.
>
>>
>> -Alan.