Publish and fetch a modular jar to a repository

Paul Sandoz paul.sandoz at oracle.com
Mon Jul 16 03:42:38 PDT 2012


On Jul 16, 2012, at 12:30 PM, Chris Hegarty wrote:
> Paul,
> 
> I've gone through these changes too, looks good to me.
> 

Thanks.


> Trivially, L281 PublishedRepository.java, the local 'len' is not needed, simply 'while (in.read(buf) != -1)'.
> 

OK.


> I also wonder in ModuleMetaData if download() and install() should be renamed to downloadSize() and installSize(), since ModuleSize -> ModuleMetaData. Just a thought when I seen the usage in Resolver.
> 

OK. s/download()/getDownloadSize()

http://cr.openjdk.java.net/~psandoz/jigsaw/repo-add-jar/webrev.2/

Paul.


More information about the jigsaw-dev mailing list