Review Request: loading JCE providers using ServiceLoader

[Alan Bateman]

On 22/07/2012 21:20, Sean Mullan wrote:On 22/07/2012 21:20, Sean Mullan 
wrote:
> :
> Yes that's the most common case. You can, however, instantiate the provider
> directly which doesn't require any configuration to the java.security file.
Although not in module mode because sun.security.pkcs11.SunPKCS11 and 
the other types are not exported.

In any case, I think the approach is a great start. It also brings up 
the issue as to whether there should be a way to configure the order of 
service providers as that is something that comes up all the time. For 
now I think it's okay to continue with listing them in java.security, 
it's just that it may have to be re-visited in the future.

BTW: One thing I noticed but didn't mention in the original mail is that 
in the jce.sh test you have a "requires service java.security.Provider" 
but that isn't needed because it's the base module that is the actual 
consumer.

> :
>> Also I think the "tries" field in ProviderConfig needs
>> to be checked as it looks to have synchronization issues. I'll try to do
>> a more detailed few in the next few days.
> I'll take a closer look at that, though that's existing code, I did not do
> anything to change that.
>
I only noticed it because there are changes in this area, might be worth 
submitting a bug so that someone remembers to look at it.

-Alan