Additional JAX-WS/JAXB services, issue with declaring service provider class

[Paul Sandoz]

On Jun 13, 2012, at 5:12 PM, Alan Bateman wrote:

> On 13/06/2012 15:00, Paul Sandoz wrote:
>> :
>> 
>> However com.sun.xml.internal.ws.spi.db.BindingContextFactory is problematic.
>> 
>> The following is generated in the jdk.jaxws module:
>> 
>> module jdk.jaxws @ 8-ea {
>>     ...
>>     requires optional service com.sun.xml.internal.ws.spi.db.BindingContextFactory;
>>     ...
>> 
>>     view jdk.jaxws.internal {
>>         ...
>>         exports com.sun.xml.internal.ws.spi.db;
>>        ...
>>     }
>> }
>> 
>> But there is no service provider class declaration in the jdk.jaxws.internal view:
>> 
>>  providers service com.sun.xml.internal.ws.spi.db.BindingContextFactory with
>>    com.sun.xml.internal.ws.db.glassfish.JAXBRIContextFactory;
>> 
>> 
>> Is this an issue with the generation of module-info files or do i need to declare some additional information in one of the files in jdk/make/modules?
>> 
>> Paul.
> I'm happy to help get the jdk.depconfig changes in.
> 
> Is there a META-INF/services/com.sun.xml.internal.ws.spi.db.BindingContextFactory that lists com.sun.xml.internal.ws.db.glassfish.JAXBRIContextFactory?

Yes there is, see:

  jaxws/src/share/jaxws_classes/com/sun/tools/etc/META-INF/services


> That probably explains why it's not in the generated module-info.
> 
> As an aside, if permits doesn't make sense with services, then I assume this eliminates the needs a non-default view to provide a service, the provides service declaration only needs to be in the default view.
> 

Yes.

I wonder if the view is confusing the module file generation code?

Paul.