RFR: jpkg contents/show commands

[Chris Hegarty]

On 19/06/12 05:24, David Holmes wrote:
> Hi Chris,
>
> Did this change not get pushed? I just did a clean clone and build and
> jpkg doesn't have these new commands.

This never got pushed. I got distracted with refactoring and the new 
Module file parser API. When this API is pushed I'll be able to update 
this proposed change to use it ( should be much cleaner ).[ Note to 
self, do not mix refactoring changes with others, just slows everything 
down! ]

Most importantly, I think we now have agreement that the jpkg tool 
should be extended to provide all commands related to the packaging of 
the module file, similar to what the jar tool provides for jar files ( 
create, list, extract, etc... )

Once I push the parser changes I'll update this webrev and try to make 
progress on it.

-Chris.

>
> David
>
> On 18/05/2012 3:04 AM, Chris Hegarty wrote:
>> This change adds two new commands to the packaging tool. 'jpkg show' and
>> 'jpkg contents', which came up on this list a few weeks ago.
>>
>> http://cr.openjdk.java.net/~chegar/jigsaw/jpkg_contents.00/webrev/
>>
>> Also, included is various cleanup and restructuring, especially to
>> ModuleFile, to put in place a structure to more easily support new
>> compression algorithms. Specifically LZMA. I have a prototype from last
>> year I need to rebase.
>>
>> For now, 'contents' and 'show' are only added jpkg, but I could see that
>> these may be useful before installing a module into the module library,
>> so could be applicable to the jmod command also? Or just jmod?
>>
>> If these new commands are to stay in jpkg long term we should probably
>> change the command that builds the jmod/deb files to create/build, so
>> 'jpkg create ... jmod'.
>>
>> Two specific implementation changes to draw attention to in the webrev:
>> 1) ModuleFile.java (L535 new file). Resources were never being
>> deflated in the module library. They are now.
>> 2) Sean,
>> Can you verify the changes to changes to Singer and
>> ModuleFile.SignatureSection? All jigsaw signing related tests pass.
>>
>> -Chris.