ServiceLoader.load* take 2

[Mandy Chung]

Paul,

On 6/12/2012 8:03 AM, Paul Sandoz wrote:
> the first part of which is implemented by the following webrev, which changes service instance creation so that it is scoped to the configuration rather than the class loader:
>
>    http://cr.openjdk.java.net/~psandoz/jigsaw/global-services/webrev/

I believe you want to discuss and push the service loader changes 
separately.  I reviewed this first part which looks good overall.

I also wonder if the new ModuleServiceLoader could just be an inner 
class in ServiceLoader and I understand your thought behind and change 
Loader.findServices to package-private.  I'm fine if you prefer to keep 
it as is.

LoaderPool.java L119 - Is 'servceInterfaceName' a typo (missing letter 
'i' in "service")

ModuleServiceLoader.java L124: does javadoc parse '<S>' correctly?

classloader.sh test - looks like you can just extend hello.sh, many.sh, 
and possibly optional.sh to test the different ServiceLoader.load* 
methods that could also be launched in a new VM if appropriate.

Mandy