Review request for the incorrect check for "getClassLoader" permission

Alan Bateman Alan.Bateman at oracle.com
Mon Jun 25 12:11:18 PDT 2012


On 25/06/2012 18:00, Mandy Chung wrote:
>
> :
>
> I see your concern of the potential mistake in merging with jdk8.   As 
> we plan to push some jdk changes in jigsaw to jdk8 regularly to keep 
> jigsaw repo with minimum change against jdk8, to prepare for it - what 
> do you think if I add a new method 
> sun.misc.VM.isSystemDomain(ClassLoader) something like that?  The jdk8 
> version of this method will just check cl == null.
VM.isSystemDomain would be fine, except perhaps for the j.u.c classes 
where we'd need to check with Doug (David or Chris might do that). The 
reason is that we try to avoid changes to the j.u.c classes in OpenJDK 
so that it makes it easier to sync up. Also the j.u.c classes are 
released standalone too and this makes it a bit awkward to have a 
dependency on a new method in sun.misc.VM. A package-private class in 
j.u.c might help there.

-Alan



More information about the jigsaw-dev mailing list