Review request for the incorrect check for "getClassLoader" permission

Alan Bateman Alan.Bateman at oracle.com
Tue Jun 26 23:44:40 PDT 2012


On 25/06/2012 21:12, Mandy Chung wrote:
> Alan, David, Paul,
>
> Given that j.u.c is pulled down from Doug's CVS into OpenJDK, I am 
> having a second thought to leave the j.u.c.atomic change out from this 
> patch.
>
> I have added a static needsPackalgeAccessCheck method in 
> sun.reflect.misc.ReflectUtil class that could be used by j.u.c.atomic 
> updater once it's integrated to jdk8.  Since this j.u.c. change isn't 
> critical for jigsaw at this time, we'll check with Doug (probably with 
> David or Chris' help) and get appropriate change made in JSR166e 
> source that will subsequently get pulled down in JDK 8 and jigsaw.
>
> Updated webrev:
>   
> http://cr.openjdk.java.net/~mchung/jigsaw/webrevs/getclassloader-permission-fix.01/
The ReflectUtil addition looks good.

I agree that the j.u.c. changes aren't really important here. I see 
David's reply suggesting that we could manage the difference so it may 
be best to have a complete fix rather than trying to remember the issues 
later.

-Alan.



More information about the jigsaw-dev mailing list