Question about FileManagers in Jigsaw.

Kelly O'Hair kelly.ohair at oracle.com
Tue Mar 13 13:53:23 PDT 2012


On Mar 13, 2012, at 12:55 PM, Alan Bateman wrote:

> On 13/03/2012 16:27, Kelly O'Hair wrote:
>> 
>> Not sure we want to fold corba, jaxp, and jaxws sources back into jdk repository. We worked hard to untangle them.
>> I'm not completely against the idea, but we need to be very careful here and think this through.
>> My preferences at this point is to leave them as separate repos and try and work with them that way.
>> 
> One thing about separate repos is that partial builds (if they are supported) would need be able to reconstitute the modules that would otherwise be built if these repos were present. Either that or the jmod packages must be present in the import JDK.

I was actually thinking that the import jdk would have the jmod packages.
But I'm a jigsaw-newbie at this point.

I was assuming that corba, jaxp, and jaxws would deliver a distinct set of modules as their deliverables,
and if those repos were not present at build time, the modules could be gotten from the import jdk.
HOWEVER, I could also see us just requiring those repositories to always exist and be built when the
jdk repository was being built. The assumption was that the build would be so fast that this would never be
a speed issue. It might then eventually make sense then that corba, jaxp, and jaxws sit inside the jdk repository,
either as nested repos or imported into it, but that's a decision for later.

The partial builds are a maintenance burden from my point of view, and there have been no end of
problems people have sent me when their partial build did not work.
When it was just j2se and hotspot, that was one thing, but the complexity of 7 repos and all combinations
of them, well, it's a bit out of control. If we can limit the variations on partial builds, that would be a good thing
in my opinion.

I had a plan of creating some top level Makefile logic that would enforce what sets of repositories were
valid to build in a partial build, e.g. top+hotspot  top+langtools+corba+jaxp+jaxws+jdk etc.
And consider a stop of the build when certain repositories were missing, or foreign ones were present, or
they were located in the wrong place or with the wrong names.
But that was a selfish act meant to stop some of the emails I get about failed builds. :^(

-kto

> 
> -Alan




More information about the jigsaw-dev mailing list