RFR: Module constraints on targets
Alan Bateman
Alan.Bateman at oracle.com
Tue Oct 16 07:25:29 PDT 2012
On 11/10/2012 17:37, Chris Hegarty wrote:
>
> This is a proposal to fulfill the 'module constraints on targets'
> requirement [1]. Essentially, support setting OS and Arch values on
> module-files and libraries. It meets the common use-cases, like
> installing platform specific modules into the wrong module library,
> when cross compiling, etc..
> :
>
> Webrev:
> http://cr.openjdk.java.net/~chegar/jigsaw/constraints.00/webrev/
This looks very good. The filtering in RepositoryCatalog means the
changes aren't intrusive to the resolver which is nice. Also the options
to jmod and jpkg are simple and consistent and good to see the identify
command updated too.
I see you've got the comment "## find a better name" in
ModuleArchitecture. The name you have works for module files, probably
less so for module libraries, particularly the Library.architecture()
method. I would be tempted to change to something like Architecture or
Platform until we get a better name but what you have is okay too.
One small comment on ModuleArchitecture is that I'm not sure about that
createFromOS and createFromArch are useful and I would be tempted to
leave them out unless we need them.
Otherwise I think this is a good work.
-Alan.
More information about the jigsaw-dev
mailing list