RFR: Post-modules and module images build in new buildsystem

[Erik Joelsson]

On 2013-03-21 23:30, Mandy Chung wrote:
> On 3/21/13 6:02 AM, Alan Bateman wrote:
>> On 21/03/2013 10:58, Erik Joelsson wrote:
>>> I have converted the post modularization step from the old build 
>>> system to the new build system in jigsaw.
>>>
>>> http://cr.openjdk.java.net/~erikj/jigsaw/webrev.post-modules.01/
>>>
>>> The images target will now produce the same module and base images 
>>> as the old build. The legacy images can still be built using the new 
>>> target "legacy-images". All the post modularization steps happen in 
>>> the target "post-modules". I have verified the build manually on 
>>> linux, windows, solaris and mac and also run it successfully through 
>>> jprt (with a limited set of tests). I've compared the contents of 
>>> the built modules with the old build (see below for differences).
>> This is great as we need to get moved off the old build system - 
>> thank you!
>
> Indeed a big thank you!  This is great and we can build jigsaw with 
> the new build! One less dependency on the old build.
>>
>> I haven't looked through all the changes yet but it may be that we 
>> just bring these in now so that we can switch to the new build. Mandy 
>> - do you agree? Mandy might wonder about the class analyzer skipping 
>> _the files but I think that is fine for now.
>
> I agree.  We should switch to the new build.  jigsaw/Makefile 
> currently still uses the old build as the default.  Can you also try 
> building with the closed repos?
>
My jprt run was with closed, but not deploy and install. Are those 
buildable with jigsaw in the old build? I'm running another job in jprt 
now with just open to make sure that too works on all platforms.


>> Do you forsee any issues or complications with future merges? It's 
>> possible we might be using post-modules for some time.
>>
>
> jigsaw is currently sync'ed with jdk8 b76.  There are other build 
> changes in jdk8 and we will find out from our next merge if there is 
> any complication.   This is good work and we can improve it over 
> time.  I support pushing this change.
>
Let me know if you need any help with the merge.

/Erik