RFR 8056141: Move com.sun.security.jgss into a new module

Wang Weijun weijun.wang at oracle.com
Thu Aug 28 13:43:03 UTC 2014


On Aug 28, 2014, at 21:06, Alan Bateman <Alan.Bateman at oracle.com> wrote:

> On 28/08/2014 14:02, Wang Weijun wrote:
>> On Aug 28, 2014, at 18:52, Alan Bateman <Alan.Bateman at oracle.com> wrote:
>> 
>>>>    http://cr.openjdk.java.net/~weijun/8056141/webrev.00/
>>>> 
>>> Max - the main thing is that is missing in this is the update to modules.xml, this is temporary document that is checked into the top-level repo until there is a module system in place. I'll defer to Mandy as to whether she wants to re-generate it or whether to edit manually (I think this will be the first adjustment since the source code restructure was pushed).
>> Webrev updated at the same URL.
>> 
>> I manually edited modules.xml, but if it can be re-generated automatically I'll be happy to use it.
>> 
> Have you run "make verify-modules"?

Oops. Succeed after more change

diff --git a/modules.xml b/modules.xml
--- a/modules.xml
+++ b/modules.xml
@@ -920,6 +920,14 @@
       <name>sun.security.krb5.internal.ktab</name>
       <to>jdk.security.auth</to>
     </export>
+    <export>
+      <name>sun.security.jgss</name>
+      <to>jdk.security.jgss</to>
+    </export>
+    <export>
+      <name>sun.security.krb5.internal</name>
+      <to>jdk.security.jgss</to>
+    </export>
   </module>
   <module>
     <name>java.security.sasl</name>
@@ -1739,7 +1747,7 @@
     <name>jdk.security.jgss</name>
     <depend>java.base</depend>
     <depend>java.logging</depend>
-    <depend>java.security.jgss</depend>
+    <depend re-exports="true">java.security.jgss</depend>
     <depend>java.security.sasl</depend>
     <export>
       <name>com.sun.security.jgss</name>

Webrev still there.

--Max

> 
> -Alan.



More information about the jigsaw-dev mailing list