On 9/13/2014 1:30 AM, Chris Hegarty wrote: > Update jdk part as per Mandy’s comments: > > http://cr.openjdk.java.net/~chegar/8058118/webrev_jdk.01/webrev/ Looks good. Thanks for the update. As Alan pointed out, it'd be good to add a private no-arg constructor to ModulesXmlReader and ModulesXmlWriter. thanks Mandy