RFR(XS): 8132475 : The commands in the modular images are executable by the owner only (once again)

[Volker Simonis]

On Tue, Jul 28, 2015 at 10:04 PM, Alan Bateman <Alan.Bateman at oracle.com> wrote:
> On 28/07/2015 19:32, Volker Simonis wrote:
>>
>> Hi,
>>
>> could you please review this tiny change:
>>
>> http://cr.openjdk.java.net/~simonis/webrevs/2015/8132475/
>> https://bugs.openjdk.java.net/browse/JDK-8132475
>>
>> After "8080511: Refresh of jimage support" the executable commands in
>> jdk/bin and jre/bin are only executable by the file owner. This means
>> that only the user who built the images can execute the programs.
>>
>> The fix is trivial, but I've also added a test now so this won't
>> happen a third time :)
>>
> This is a new image writer, it's different to what was there previously.
>

Just for the case it is changed once again :)

> I assume the test can't run if the permissions are not right :-)
>

Of coarse it can't run if there are no executable permissions at all,
but it will run and give an error if only the owner of the file has
executable permissions which is what this bug is all about. Obviously,
you (i.e. Oracle) are running all the tests with the same user who
also built the VM that's why you didn't saw this problem two times. We
have a distinct build and test users (which I think is good) so we
always run into this instantly.

Regards,
Volker

> -Alan.