Review Request: 8074428, 8074429, 8074430 jdk.pack200, jdk.jartool, jdk.policytool modules

Mandy Chung mandy.chung at oracle.com
Thu Mar 5 03:25:16 UTC 2015


On 3/4/2015 6:55 PM, Wang Weijun wrote:
> I am about to introduce 2 APIs into jdk.dev so that people can call functions of keytool and jarsigner directly.

Are you referring to these 2 RFEs?
https://bugs.openjdk.java.net/browse/JDK-8056174
https://bugs.openjdk.java.net/browse/JDK-8058778

We have to see the details and webrev to comment on your
proposed jdk.security.tools and jdk.security.util modules.

There is no issue in keeping a CLI like keytool in java.base.
What is your concern?

policytool is a GUI app that depends on java.desktop module.
If you move jarsigner, policytool and keytool, this new module
would require java.desktop to be present to be used.

Mandy

> So what I am suggesting is
>
> - Create jdk.security.util
> - Move jarsigner, policytool to jdk.security.util
> - Create the new APIs in this module
> - Move keytool to jdk.security.util, it's now in java.base but keytool is not part of Java SE spec (Of course, if that means keytool will be in JDK instead of JRE please stop. But will there will the name difference anymore? I am thinking of an installer like cygwin that you can choose anything except that java.base is checked grayed).
>
> Or, we can break it into jdk.security.tools and jdk.security.util. Put the executables into tools and APIs into util.
>
> --Max
>
>> On Mar 5, 2015, at 09:13, Mandy Chung <Mandy.Chung at oracle.com> wrote:
>>
>> As listed in an open issue in JEP 200:
>>
>> The jdk.dev and jdk.runtime modules contain miscellaneous tools that do
>> not obviously belong to any other module; these modules will eventually
>> be either renamed or refactored.
>>
>> Currently there are jdk.javadoc, jdk.jconsole, jdk.jcmd modules in
>> the JDK that are organized around its primary tool.  Such organization
>> is easy to name, document and understand. This patch proposes to
>> move tools from jdk.runtime and jdk.dev to jdk.pack200, jdk.jartool,
>> jdk.policytool modules.
>>
>> Overall Webrev that will be convenient to review the build change
>> and modules.xml change.
>>    http://cr.openjdk.java.net/~mchung/jdk9/webrevs/8074428%2b8074429%2b8074430/webrev.00/
>>
>> Separate webrevs for each issue:
>> 1. pack200, unpack200 to jdk.pack200
>>
>> http://cr.openjdk.java.net/~mchung/jdk9/webrevs/8074428%2b8074429%2b8074430/8074428/webrev.00/
>>
>> 2. jar, jarsigner to jdk.jartool
>>
>> http://cr.openjdk.java.net/~mchung/jdk9/webrevs/8074428%2b8074429%2b8074430/8074429/webrev.00/
>>
>> 3. policytool to jdk.policytool
>>
>> http://cr.openjdk.java.net/~mchung/jdk9/webrevs/8074428%2b8074429%2b8074430/8074430/webrev.00/
>>
>> There are remaining tools in jdk.dev that will be handled separately.
>> jdk.dev will disappear when all of the remaining tools find its home.
>>
>> Mandy
>>



More information about the jigsaw-dev mailing list