RFR 8047789: auth.login.LoginContext needs to be updated to work with modules
Alan Bateman
Alan.Bateman at oracle.com
Sat Mar 21 10:54:19 UTC 2015
On 20/03/2015 14:39, Wang Weijun wrote:
> Please review the code changes at
>
> http://cr.openjdk.java.net/~weijun/8047789/webrev.03/
>
> :
>
> Compatibility issue: Before this code change, any class that includes the necessary methods (initialize, login, logout, abort, commit) can be configured as a login module, which does not necessarily implement the LoginModule interface itself. After this code change, it must implement the interface.
>
> We might need to update the JAAS programming guide in Java SE documentation to describe the new loading mechanism.
>
I think the changes look reasonable too. A minor suggestion is to change
the existing comment "instantiate the LoginModule" to "locate and
instantiate ...".
On the compatibility issue then someone creating a JAAS configuration
file that lists a <LoginModule> that is not a LoginModule will cause CCE
but this pops out as a LoginException with the CCE as cause now - right?
This may be something for release notes.
It would be good to get the JAAS documentation updated too.
-Alan
More information about the jigsaw-dev
mailing list