RFR: 8139430
Mandy Chung
mandy.chung at oracle.com
Wed Nov 11 00:45:47 UTC 2015
> On Nov 10, 2015, at 12:42 PM, Alan Bateman <alan.bateman at oracle.com> wrote:
>
> Would it break many tests if getProcessId were changed to return long to match ProcessHandle::getPid?
There are not small number of tests doing
Integer.toString(ProcessTools.getProcessId()));
Most of them are in hotspot and there are about 10 in jdk repo. Perhaps the tests should simply be changed to call:
ProcessHandle.current().getPid();
>
> When this is pushed then can we drop @modules java.management from any tests or were those changes held back assuming the dependency would be dropped?
I think Shura prefers to do this patch on ProcessTools and update the dependency in another bulk update. It’d be good if this can be done together.
Mandy
More information about the jigsaw-dev
mailing list