Review request for JDK-8141338: Move jdk.internal.dynalink package to jdk.dynalink
mandy.chung at oracle.com
Mon Nov 23 15:45:12 UTC 2015
> On Nov 23, 2015, at 7:40 AM, Alan Bateman <alan.bateman at oracle.com> wrote:
> On 23/11/2015 15:27, Attila Szegedi wrote:
>> I integrated the changes Mandy suggested; please review these (build related) changes:
>> jdk9 top level: <http://cr.openjdk.java.net/~attila/8141338/webrev.jdk9.top.2/index.html>
>> jdk9/jdk: <http://cr.openjdk.java.net/~attila/8141338/webrev.jdk9.top.2/index.html>
>> For the sake of completeness, the jdk/nashorn changes are here: <http://cr.openjdk.java.net/~attila/8141338/webrev.jdk9> but they have already been reviewed by Hannes and Sundar; only the above two (jdk9 and jdk9/jdk) have been modified compared to the original review request.
>> Sundar was kind enough to verify that JDK9 builds fine with these changes.
> The jdk repo looks okay (just had to change your link to find it :-)
> In the top-level repo then you've moved jdk.scripting.nashorn from PROVIDER_MODULES to MAIN_MODULES. The reason that we've had it in PROVIDER_MODULES is because we treat it as a service provider module (it provides an implementation of javax.script.ScriptEngineFactory).
jdk.scripting.nashorn now exports two API packages. It is no longer a sole service provider and so I asked Attila to move it MAIN_MODULE.
More information about the jigsaw-dev