RFR 8135972: Implement new tests for native libjimage library

Alan Bateman Alan.Bateman at oracle.com
Tue Nov 24 08:29:50 UTC 2015


On 24/11/2015 00:37, Sergei Pikalev wrote:
>
> Hi All,
>
> http://cr.openjdk.java.net/~jlaskey/8135972/webrev.01/index.html
>
> There are a minimal set of passing cleanly tests which does not explore
> bad values touching memory addresses.
>
> Please review.
I assume Jim or Jean-Francois will sponsor this for you. Is 
JImagePackageToModuleTest the only test that is unique to jake? I'm just 
wondering if we can get these tests into via jdk9/dev.

One thing that isn't clear to me is the multipleOpenTest, I would have 
expected a second call to JIMAGE_Open to return a unique handle.

A small comment on JImageOpenCloseTest - I assume this should create the 
0-length or bad-magic jimage file rather than checking in binary files.

-Alan


More information about the jigsaw-dev mailing list