RFR 9: 8139390 : Very long classname in jimage causes SIGSEGV
Roger Riggs
roger.riggs at oracle.com
Wed Oct 28 15:25:23 UTC 2015
Hi Alan,
Yes, it uses the JNU_CHECK_EXCEPTION_RETURN macros.
If it would be cleaner to remove the jni_util.h include, the macros can
be replaced.
They don't add much value in this case.
Thanks, Roger
On 10/28/15 8:15 AM, Alan Bateman wrote:
>
>
> On 28/10/2015 06:40, Roger Riggs wrote:
>> Please review an update to the jimage reader implementation to
>> correct the
>> case where a class name is very long causing a SEGV due to buffer
>> overruns.
>>
>> The fix will be pushed to the hs-comp repo; the bug was first spotted
>> there.
>>
>> Webrev:
>> http://cr.openjdk.java.net/~rriggs//webrev-jimage-segv-8139390
>>
>> Issue:
>> https://bugs.openjdk.java.net/browse/JDK-8139390
> The new ThrowByName reminded me to ask if jni_util.h is needed. As
> libjimage doesn't link to libjava then there won't be any dependences
> but perhaps some of the macros are used?
>
> -Alan
More information about the jigsaw-dev
mailing list