RFR 8153928, test/lib/share/classes/jdk/test/lib/Utils.java introduced dependency to java.base/jdk.internal.misc

Felix Yang felix.yang at oracle.com
Mon Apr 11 06:57:37 UTC 2016


Hi Alan and Amy,
     thanks for figuring this out. Updated to suggested practice.

New webrev: http://cr.openjdk.java.net/~xiaofeya/8153928/webrev.01/

Felix

On 2016/4/11 14:46, Alan Bateman wrote:
> On 11/04/2016 06:04, Felix Yang wrote:
>> Amy,
>>     thanks. I'm not sure which practices are suggested. By searching 
>> the existing tests, I found lots of test with 2+ @modules, so I chose 
>> to add another @modules. Personally, both ways look clear and 
>> transparent for me.
> We've tried to use one @modules per test but there are 
> inconsistencies. I think some of those inconsistencies arose when 
> patches were brought into jdk9/dev early and then subsequently merged. 
> At some point we should do a pass over the existing usages to get them 
> consistent.
>
> -Alan



More information about the jigsaw-dev mailing list