RFR: JDK-8069079 - jimage extract / list to organize classes by modules
Jim Laskey (Oracle)
james.laskey at oracle.com
Sun Apr 24 11:50:17 UTC 2016
Thank you, changes incorporated.
> On Apr 22, 2016, at 2:08 PM, Mandy Chung <mandy.chung at oracle.com> wrote:
>
> Hi Jim,
>
>> On Apr 22, 2016, at 6:12 AM, Jim Laskey (Oracle) <james.laskey at oracle.com> wrote:
>>
>> Listing is by module, extract has been by module for some time.
>>
>> http://cr.openjdk.java.net/~jlaskey/8069079/webrev/index.html <http://cr.openjdk.java.net/~jlaskey/8069079/webrev/index.html>
>
>
> JDK-8069079 was filed long time ago and I now retested it. jimage list and extract in jdk9 works as what I'd like to see when filing the issue.
>
> $ ./bin/jimage list lib/modules
>
> jimage: modules
> /java.activation/META-INF/mailcap.default
> /java.activation/META-INF/mimetypes.default
> /java.activation/com/sun/activation/registries/LineTokenizer.class
> /java.activation/com/sun/activation/registries/LogSupport.class
> :
>
> The current output looks fine to me. This issue can be issued.
>
> A minor comment (a separate issue):
>
> jimage: modules
>
> It would help to print the path supplied in the command line than just the base filename.
>
> $ ./bin/jimage list
>
> This silently returns. Since the list/extract command requires to specify the path to the jimage file, it would be helpful to report that.
>
> Mandy
More information about the jigsaw-dev
mailing list