RFR JDK-8155005: java.lang.reflect.Module.WeakSet is not thread-safe

[Claes Redestad]

On 2016-04-25 15:02, Alan Bateman wrote:
> On 25/04/2016 13:54, Claes Redestad wrote:
>> Hi,
>>
>> I think this looks good, but since these WeakPairMaps won't be used 
>> for many applications I wonder if it's worth keeping the 
>> implementation lazy, for example by moving the maps to a holder class:
>>
>> http://cr.openjdk.java.net/~redestad/scratch/transients.01/
>>
>> I verified this avoids loading the WeakPairMap class for various 
>> small programs and should be neutral in other regards.
> This looks like it saves loading one class and not sure that it's 
> worth it. Also I expect there will be quite a bit of refactoring and 
> changes as we work through issues over the next months few months.

Sure - also saves creating and holding the three maps eagerly - but I 
agree the saving might not justify the added complexity in this case.

/Claes