RFR JDK-8151913: Fix module dependencies in java/net tests

John Jiang sha.jiang at oracle.com
Thu Apr 28 05:34:06 UTC 2016


Hi Amy,
That's case to case.
If a test is using java.logging APIs directly, I declared the module for 
the test. Otherwise, I didn't.
I think that may be more clear.
Although a test is using jdk.httpserver, that doesn't mean it also 
dependents on java.logging.

Best regards,
John Jiang

On 2016/4/28 13:09, Amy Lu wrote:
> On 4/28/16 12:50 PM, John Jiang wrote:
>> Hi,
>> Please review another webrev: 
>> http://cr.openjdk.java.net/~jjiang/8151913/webrev.02
>> The java.httpclient module declaration is removed from all of 
>> java/net/httpclient tests, even though some ones have to declare 
>> other modules.
>
> + * @modules jdk.httpserver
> + *          java.logging
>
> Not necessary to declare java.logging as it’s a dependency of 
> jdk.httpserver
> (it does not hurt, though)
>
> Please wait for reviewer's feedback...
>
> Thanks,
> Amy
>>
>> Best regards,
>> John Jiang
>>
>>
>> On 2016/4/27 23:07, John Jiang wrote:
>>> Hi Alan, Felix,
>>> Thanks for your comments.
>>> Please review the updated webrev: 
>>> http://cr.openjdk.java.net/~jjiang/8151913/webrev.01/
>>>
>>> Best regards,
>>> John Jiang
>>>
>>>
>>> On 2016/4/27 15:08, John Jiang wrote:
>>>> Hi,
>>>> Please review the fix for explicitly declaring module dependencies 
>>>> for java net tests.
>>>>
>>>> Issue: https://bugs.openjdk.java.net/browse/JDK-8151913
>>>> Webrev: http://cr.openjdk.java.net/~jjiang/8151913/webrev.00
>>>>
>>>> Best regards,
>>>> John Jiang
>>>>
>>>>
>>>
>>>
>>
>
>



More information about the jigsaw-dev mailing list