8154956: Module system implementation refresh (4/2016)
Chris Hegarty
chris.hegarty at oracle.com
Sat Apr 30 10:55:17 UTC 2016
> On 30 Apr 2016, at 05:48, Mandy Chung <mandy.chung at oracle.com> wrote:
>
>
>> On Apr 29, 2016, at 5:38 AM, Alan Bateman <alan.bateman at oracle.com> wrote:
>>
>> The webrevs, all repos are here:
>> http://cr.openjdk.java.net/~alanb/8154956/1/
>
> I reviewed all repos except hotspot. Looks good in general. Minor comments:
>
> Configuration.java
> Nit: line 361-364 there is an extra space
>
> sun/tools/jar/Main.java
> In the printModuleDescriptor method, creating a List from a stream is not necessary.
> 1668 md.requires().stream().sorted().collect(toList()).forEach(
>
> sortExports can be replaced as well.
>
> I have a patch to clean this up that I can push to jake:
> http://cr.openjdk.java.net/~mchung/jigsaw/webrevs/jar-jmod-cleanup/
Thank you Mandy, I attempted to clean this up recently, but your further updates are much better.
-Chris.
More information about the jigsaw-dev
mailing list