8154956: Module system implementation refresh (4/2016)

[Andrej Golovnin]

Hi Claes,

> diff -r 930fcc6b74c8 src/java.base/share/classes/java/lang/module/ModulePath.java
> --- a/src/java.base/share/classes/java/lang/module/ModulePath.java Fri Apr 29 18:47:24 2016 -0700
> +++ b/src/java.base/share/classes/java/lang/module/ModulePath.java Sat Apr 30 16:03:03 2016 +0200
> @@ -267,8 +267,9 @@
> 
>             if (attrs.isDirectory()) {
>                 return readExplodedModule(entry); // may return null
> -            } if (attrs.isRegularFile()) {
> -                String fn = entry.getFileName().toString();
> +            }
> +            String fn = entry.getFileName().toString();
> +            if (attrs.isRegularFile()) {
>                 if (fn.endsWith(".jar")) {
>                     return readJar(entry);
>                 } else if (fn.endsWith(".jmod")) {
> @@ -279,7 +280,6 @@
>             }
> 
>             // skip hidden files
> -            String fn = entry.getFileName().toString();
>             if (fn.startsWith(".") || Files.isHidden(entry)) {
>                 return null;
>             } else {

I have a stupid question: Is it guaranteed that entry.getFileName().toString always
returns a value in lowercase?

Best regards,
Andrej Golovnin