RFR 8162782: jlink ResourcePool.releaseProperties should be removed

Sundararajan Athijegannathan sundararajan.athijegannathan at oracle.com
Mon Aug 1 16:31:25 UTC 2016


I had moved that try..catch code to read module descriptor from
elsewhere.  When I removed that try..catch, I got test failures. Found
another lurking issue on reading descriptor from compressed resources!
Fixed that [ImagePluginStack.LastPoolManager] and removed try..catch.
All tests pass now. Also fixed the comment for ResourcePoolEntry.Type.TOP

Please review updated webrev @
http://cr.openjdk.java.net/~sundar/8162782/webrev.01/index.html

Thanks,

-Sundar


On 8/1/2016 5:52 PM, Alan Bateman wrote:
>
>
> On 31/07/2016 20:29, Sundararajan Athijegannathan wrote:
>> Hi,
>>
>> I'll handle that issue in another fix.
>>
>>
> Okay. One thing with the current patch is that the try/catch in
> releaseProperties isn't clear. Also in ResourcePoolEntry, where it
> defines TOP, it says "jdk image directory" then I assume it should say
> "run-time image" as it's not specific to JDK images. The rest looks
> okay to me.
>
> -Alan



More information about the jigsaw-dev mailing list