RFR: 8156499 Update jlink to support creating images with modules that are packaged as multi-release JARs
Alan Bateman
Alan.Bateman at oracle.com
Mon Aug 8 08:57:51 UTC 2016
On 06/08/2016 00:43, Steve Drach wrote:
> Hi,
>
> Please review this changset that makes jlink multi-release jar aware.
>
> issue: https://bugs.openjdk.java.net/browse/JDK-8156499 <https://bugs.openjdk.java.net/browse/JDK-8156499>
> webrev: http://cr.openjdk.java.net/~sdrach/8156499/webrev.00/index.html <http://cr.openjdk.java.net/~sdrach/8156499/webrev.00/index.html>
>
Are you sure that this is right? I ask because it looks like it appears
to ignore all resources in the JAR file that don't start with
META-INF/versions/<N>. The other thing is that it is uses
jarFile.version() which isn't right. At some point (maybe a future
patch) then it need to be using the version of java.base.
Also I assume the test needs work so that it passes when run on an
exploded image.
-Alan
More information about the jigsaw-dev
mailing list