RFR: 8163126 Wrong @modules in some of jdk/* tests

Alexandre (Shura) Iline alexandre.iline at oracle.com
Wed Aug 17 16:40:58 UTC 2016


Thank you!

Fixed in place:
http://cr.openjdk.java.net/~shurailine/8163126/webrev.00/test/jdk/security/jarsigner/Spec.java.sdiff.html

Shura

> On Aug 16, 2016, at 6:48 PM, Wang Weijun <weijun.wang at oracle.com> wrote:
> 
> 
>> On Aug 17, 2016, at 9:26 AM, Alexandre (Shura) Iline <alexandre.iline at oracle.com> wrote:
>> 
>> Before the suggested fix, the test in question would fail on a system with no jdk.crypto.pkcs11. That could be emulated by:
>> $ jtreg ... -javaoptions:"-limitmods jdk.jartool" jdk/security/jarsigner/Spec.java
>> ...
>> FAILED: jdk/security/jarsigner/Spec.java
>> ...
>> $ jtreg ... -javaoptions:"-limitmods jdk.jartool,jdk.crypto.pkcs11" jdk/security/jarsigner/Spec.java
>> ...
>> Passed: jdk/security/jarsigner/Spec.java
>> ...
>> $ 
> 
> Thanks very much for the detailed answer.
> 
> Just a small suggestion: Can you try using jdk.crypto.ec module instead? It also provides all EC-related algorithms and it is available and loaded out-of-box on all platforms?
> 
> --Max
> 



More information about the jigsaw-dev mailing list