RFR 8164800: Cross targeting Windows
Jim Laskey (Oracle)
james.laskey at oracle.com
Fri Aug 26 15:50:02 UTC 2016
+1
> On Aug 26, 2016, at 11:54 AM, Sundararajan Athijegannathan <sundararajan.athijegannathan at oracle.com> wrote:
>
> Hi,
>
> Fixed as suggested: http://cr.openjdk.java.net/~sundar/8164800/webrev.02/
>
> * Field name changed to targetOsName
>
> * Throwing RuntimeException if os name can't be determined from java.base
>
> -Sundar
>
>
> On 8/26/2016 7:30 PM, Alan Bateman wrote:
>> On 26/08/2016 14:51, Sundararajan Athijegannathan wrote:
>>
>>> Please review http://cr.openjdk.java.net/~sundar/8164800/webrev.01/ for
>>> https://bugs.openjdk.java.net/browse/JDK-8164800
>>>
>>>
>> What would you think about rename osName to targetOsName to make it
>> clearer?
>>
>> Also in releaseProperties then I wonder if it should be an error if
>> java.base's osName returns null. If you don't agree then maybe it is
>> at least a warning.
>>
>> -Alan
>
More information about the jigsaw-dev
mailing list